Remove useless ReportNode locale report and set tests locale default to stabilize report node tests #1225
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vidaldid-rte
reviewed
May 2, 2025
src/main/java/com/powsybl/openloadflow/ac/outerloop/ReactiveLimitsOuterLoop.java
Show resolved
Hide resolved
vidaldid-rte
reviewed
May 2, 2025
src/test/java/com/powsybl/openloadflow/ac/AcLoadFlowEurostagTutorialExample1Test.java
Outdated
Show resolved
Hide resolved
…to stabilize report node tests Signed-off-by: CARON Alice <alice.caron@rte-france.com>
Signed-off-by: CARON Alice <alice.caron@rte-france.com>
Signed-off-by: CARON Alice <alice.caron@rte-france.com>
|
olperr1
changed the title
vidaldid-rte
approved these changes
May 15, 2025
github-project-automation
bot
moved this from Waiting for review
to Approved
in Release 06/2025
jeandemanged
approved these changes
May 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
No
What kind of change does this PR introduce?
Clean tests related to reports, set the US locale for the tests to stabilize them regardless of the machine environment running the tests. Remove useless test reports_en.properties (according to the core MR that will now set the default locale as the report default locale (see core#3406)).
What is the current behavior?
The tests about reports are sensible to the default locale and need an empty reports_en.properties to be successfull with the message template translation.
What is the new behavior (if this is a feature change)?
The tests on reports always set the locale US to ensure the tests will run successfully regardless the default locale of the machine running the tests.
Does this PR introduce a breaking change or deprecate an API?
If yes, please check if the following requirements are fulfilled
What changes might users need to make in their application due to this PR? (migration steps)
Other information: