-
Notifications
You must be signed in to change notification settings - Fork 94
Refresh credentials atomically #444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
keithduncan
wants to merge
26
commits into
pplu:master
Choose a base branch
from
keithduncan:keithduncan/atomic-credential-refresh
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Refresh credentials atomically #444
keithduncan
wants to merge
26
commits into
pplu:master
from
keithduncan:keithduncan/atomic-credential-refresh
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lemented on Paws::Credential any more
This needs to be passed through in cases where the creds have already been retrieved to avoid shearing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have implemented a draft fix for #443. This changes the
Paws::Credential
API contract to have arefresh
method to retrieve the providers' credentials rather than exposingaccess_key
,secret_key
, andsession_token
directly.Pushing all accesses though a method which returns a single product type means field retrieval cannot be sheared by a refresh between reads.
I have reused the
Paws::Credential::Explicit
type as the return value fromrefresh
as it is already a product type of these three fields. I did and still do consider creating a new type which includes anexpiration
field so that the fields carry their expiration with them rather than it being a property of the provider.There is more work that can be done on the providers' error handling. When we have a cached credential and are pre-emptively refreshing we can return the cached credential instead of failing to refresh.
I think we could also refactor some of the common refresh code, cache and expiration handling out of the providers and into the
Paws::Credential
role.