Remove TODO regarding unrolling of gen_matrix()

hanno-becker · hanno-becker · commit 5cdbeea22c17 · 2024-12-03T10:35:30.000Z
Our performance numbers suggest that the unrolling either already
works or is not needed, so remove the corresponding TODO.

Signed-off-by: Hanno Becker &lt;beckphan@amazon.co.uk&gt;
diff --git a/mlkem/indcpa.c b/mlkem/indcpa.c
@@ -293,13 +293,6 @@ void gen_matrix(polyvec *a, const uint8_t seed[MLKEM_SYMBYTES], int transposed)
     memcpy(seedxy[j], seed, MLKEM_SYMBYTES);
   }
 
-  /*
-   * TODO: All loops in this function should be unrolled for decent
-   * performance.
-   * Either add suitable pragmas, or split gen_matrix according to MLKEM_K
-   * and unroll by hand.
-   */
-
   for (i = 0; i < (MLKEM_K * MLKEM_K / KECCAK_WAY) * KECCAK_WAY;
        i += KECCAK_WAY)
   {

Original file line number	Diff line number	Diff line change
`@@ -293,13 +293,6 @@ void gen_matrix(polyvec *a, const uint8_t seed[MLKEM_SYMBYTES], int transposed)`
`293`	`293`	`memcpy(seedxy[j], seed, MLKEM_SYMBYTES);`
`294`	`294`	`}`
`295`	`295`
`296`		`- /*`
`297`		`- * TODO: All loops in this function should be unrolled for decent`
`298`		`- * performance.`
`299`		`- * Either add suitable pragmas, or split gen_matrix according to MLKEM_K`
`300`		`- * and unroll by hand.`
`301`		`- */`
`302`		`-`
`303`	`296`	`for (i = 0; i < (MLKEM_K * MLKEM_K / KECCAK_WAY) * KECCAK_WAY;`
`304`	`297`	`i += KECCAK_WAY)`
`305`	`298`	`{`