Fix illegal instruction on x86_64 CPUs without AVX2 support #1099
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #1086 Remove automatic AVX2 flags from auto.mk for all x86_64 systems and add explicit AVX2 flags to CI workflows for x86_64 systems using nix-shell. Signed-off-by: Matthias J. Kannwischer <matthias@kannwischer.eu>
| @@ -5,7 +5,6 @@ | |||
| # Native compilation | |||
| ifeq ($(CROSS_PREFIX),) | |||
| ifeq ($(HOST_PLATFORM),Linux-x86_64) | |||
| CFLAGS += -mavx2 -mbmi2 -mpopcnt -maes | |||
There was a problem hiding this comment.
Would we not want to try to detect if the host platform supports AVX2?
There was a problem hiding this comment.
How would you detect it?
I think gcc should do the right thing by default in most setups.
In nix it doesn't which is why we need to pass explicit flags.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1086
This PR prevents illegal instruction errors on x86_64 CPUs that don't support AVX2 by:
The fix ensures compatibility with older x86_64 CPUs while maintaining optimized builds in controlled CI environments.