Skip to content

Add a setting for error message of LspHover #1601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 23 additions & 4 deletions autoload/lsp/internal/document_hover/under_cursor.vim
Original file line number Diff line number Diff line change
Expand Up @@ -81,11 +81,30 @@ function! lsp#internal#document_hover#under_cursor#getpreviewwinid() abort
return v:null
endfunction

function s:check_hover_response_empty(response) abort
if !has_key(a:response, 'result')
return 1
endif

if empty(a:response['result'])
return 1
endif

if empty(a:response['result']['contents'])
return 1
endif

return 0
endfunction

function! s:show_hover(ui, server_name, request, response) abort
if !has_key(a:response, 'result') || empty(a:response['result']) ||
\ empty(a:response['result']['contents'])
call lsp#utils#error('No hover information found in server - ' . a:server_name)
return
if s:check_hover_response_empty(a:response)
if g:lsp_hover_echo_empty_message
call lsp#utils#error('No hover information found in server - ' . a:server_name)
return
else
return
endif
endif

echo ''
Expand Down
13 changes: 13 additions & 0 deletions doc/vim-lsp.txt
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,7 @@ CONTENTS *vim-lsp-contents*
g:lsp_fold_enabled |g:lsp_fold_enabled|
g:lsp_hover_conceal |g:lsp_hover_conceal|
g:lsp_hover_ui |g:lsp_hover_ui|
g:lsp_hover_echo_empty_message |g:lsp_hover_echo_empty_message|
g:lsp_ignorecase |g:lsp_ignorecase|
g:lsp_log_file |g:lsp_log_file|
g:lsp_log_verbose |g:lsp_log_verbose|
Expand Down Expand Up @@ -1080,6 +1081,18 @@ g:lsp_hover_ui *g:lsp_hover_ui*
let g:lsp_hover_ui = 'float'
let g:lsp_hover_ui = 'preview'

g:lsp_hover_echo_empty_message *g:lsp_hover_echo_empty_message*
Type: |Boolean|
Default: `1`

Determines whether or not to echo empty hover messages. Set to `1` to
enable.

Example: >
let g:lsp_hover_echo_empty_message = 1
let g:lsp_hover_echo_empty_message = 0


g:lsp_ignorecase *g:lsp_ignorecase*
Type: |Boolean|
Default: the value of 'ignorecase'
Expand Down
1 change: 1 addition & 0 deletions plugin/lsp.vim
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,7 @@ let g:lsp_show_workspace_edits = get(g:, 'lsp_show_workspace_edits', 0)
let g:lsp_fold_enabled = get(g:, 'lsp_fold_enabled', 1)
let g:lsp_hover_conceal = get(g:, 'lsp_hover_conceal', 1)
let g:lsp_hover_ui = get(g:, 'lsp_hover_ui', '')
let g:lsp_hover_echo_empty_message = get(g:, 'lsp_hover_echo_empty_message', 1)
let g:lsp_ignorecase = get(g:, 'lsp_ignorecase', &ignorecase)
let g:lsp_semantic_enabled = get(g:, 'lsp_semantic_enabled', 0)
let g:lsp_semantic_delay = get(g:, 'lsp_semantic_delay', 500)
Expand Down
Loading