Persistent theme selector #6
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added theme selector, styles, cookie for persistent, selectable theme
removed styling specific to my site
changed a couple classed to IDs
|
Thanks for finding the time to contribute but I am not sure if user theme selection for ace editor is a feature that everyone will need. I think from a UI/UX perspective its better to keep the theme of ace editor to match the theme of tinyMCE editor. In case theme selection is a requirement then developers can create a general option in there app settings to ask the user's theme choice. Then this selected theme choice should be applied to both TinyMCE and AceEditor. I'll keep the PR open in case someone wants this; we might add it officially in the future. Even when we'll add it, we'll need to make this feature optional and fully configurable, including adding it to classic mode and not just the modal dialog view. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added theme selector, persistence, and supporting styles.