Update FoV dynamically when HMD FoV changes#372
Open
Asxcvbn wants to merge 2 commits intopraydog:masterfrom
Open
Update FoV dynamically when HMD FoV changes#372Asxcvbn wants to merge 2 commits intopraydog:masterfrom
Asxcvbn wants to merge 2 commits intopraydog:masterfrom
Conversation
Author
|
Sorry for the awkward commit title. It is written without much mind and as a sentence it looks incorrect. We can fix it later when merging if it got updated and merged later. |
7e13e5d to
a9d3f21
Compare
Author
|
Selected road (B): Implemented FOV change detection for dynamic projection matrix updates.
|
|
@Asxcvbn you might update your PR title if you can. Maybe: I tested it and it works great! @praydog this MR is a great improvement for users with 3D displays that use VRto3D, WibbleWobble, etc. It allows us to change the FoV dynamically to adjust the strength of the 3D effect. It is also useful for quickly finding the right horizontal FoV for the gameplay. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#371
Note that this is a very simple and awkward fix of the issue and I dont think it is good to merge yet. I need some help improving it.
Key idea: OpenXR::update_matrices() is, i guess, called every frame. The projection matrix(for intricsic parameters) update are somehow skipped in the function. And since convergence settings are effectly changing the intricsic parameters, we got convergence settings ignored in uevr. So to fix it, we just force the projection matrix update every 100frames (in case it is expensive, which looks unlikely).
To improve it, I have 2 ideas.