test: Fix tests for Preact > 10.16 #37
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rschristian
commented
Aug 25, 2024
rschristian
force-pushed
the
tests/preact-10.16
branch
2 times, most recently
from
c8a432d to
e551281
Compare
JoviDeCroock
approved these changes
Oct 14, 2024
rschristian
commented
Oct 14, 2024
Comment on lines
243
to
245
| // We should never re-invoke <A /> while loading <B /> (that would be a remount of the old route): | ||
| // ...but we do | ||
| //expect(A).not.to.have.been.called; |
There was a problem hiding this comment.
This is (one of) the failing situations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Adding here for posterity)
There's a few failing checks regarding currently mounted routes being re-invoked during a suspense nav due to preactjs/preact@f1eed0e
As this is how context should normally work, we're going to call it okay for now and move on.