Skip to content

Add video cache TTL enforcement for /vtrack endpoint #4136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Add video cache TTL enforcement for /vtrack endpoint #4136

wants to merge 9 commits into from
+573 −109

Conversation

@AntoxaAntoxic
Copy link
Collaborator

@AntoxaAntoxic AntoxaAntoxic commented Aug 13, 2025 •
edited by osulzhenko
Loading

🔧 Type of changes

  • new bid adapter
  • bid adapter update
  • new feature
  • new analytics adapter
  • new module
  • module update
  • bugfix
  • documentation
  • configuration
  • dependency update
  • tech debt (test coverage, refactorings, etc.)

✨ What's the context?

What's the context for the changes?

🧠 Rationale behind the change

Why did you choose to make these changes? Were there any trade-offs you had to consider?

🔎 New Bid Adapter Checklist

  • verify email contact works
  • NO fully dynamic hostnames
  • geographic host parameters are NOT required
  • direct use of HTTP is prohibited - implement an existing Bidder interface that will do all the job
  • if the ORTB is just forwarded to the endpoint, use the generic adapter - define the new adapter as the alias of the generic adapter
  • cover an adapter configuration with an integration test

🧪 Test plan

How do you know the changes are safe to ship to production?

🏎 Quality check

  • Are your changes following our code style guidelines?
  • Are there any breaking changes in your code?
  • Does your test coverage exceed 90%?
  • Are there any erroneous console logs, debuggers or leftover code in your changes?

@AntoxaAntoxic AntoxaAntoxic self-assigned this Aug 13, 2025
@osulzhenko osulzhenko requested a review from CTMBNara August 22, 2025 07:10
CTMBNara
CTMBNara previously approved these changes Sep 24, 2025
View reviewed changes
Base automatically changed from vtrack-get to master October 22, 2025 12:44
@CTMBNara CTMBNara dismissed their stale review October 22, 2025 12:44

The base branch was changed.

AntoxaAntoxic and others added 3 commits October 22, 2025 15:48
@AntoxaAntoxic
Merge remote-tracking branch 'origin/master' into vtrack-account-ttl
fdfb885 
# Conflicts:
#	src/main/java/org/prebid/server/cache/CoreCacheService.java
#	src/main/java/org/prebid/server/handler/GetVtrackHandler.java
#	src/main/java/org/prebid/server/metric/CacheVtrackMetrics.java
#	src/main/java/org/prebid/server/metric/Metrics.java
#	src/test/groovy/org/prebid/server/functional/service/PrebidServerService.groovy
#	src/test/groovy/org/prebid/server/functional/tests/CacheSpec.groovy
#	src/test/java/org/prebid/server/cache/CoreCacheServiceTest.java
@AntoxaAntoxic
Fix conflicts
3546261
@marki1an
Resolve test conflict
2408519
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CTMBNara CTMBNara CTMBNara left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@AntoxaAntoxic AntoxaAntoxic

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@AntoxaAntoxic @CTMBNara @osulzhenko @marki1an