Skip to content

Conversation

@danielbaud
Copy link

@danielbaud danielbaud commented Sep 26, 2025

🔧 Type of changes

  • new bid adapter
  • bid adapter update
  • new feature
  • new analytics adapter
  • new module
  • module update
  • bugfix
  • documentation
  • configuration
  • dependency update
  • tech debt (test coverage, refactorings, etc.)

✨ What's the context?

We want to add our own adapter that we are also adding in the main (go) version

🔎 New Bid Adapter Checklist

  • verify email contact works
  • NO fully dynamic hostnames
  • geographic host parameters are NOT required
  • direct use of HTTP is prohibited - implement an existing Bidder interface that will do all the job
  • if the ORTB is just forwarded to the endpoint, use the generic adapter - define the new adapter as the alias of the generic adapter
  • cover an adapter configuration with an integration test

🧪 Test plan

How do you know the changes are safe to ship to production?

🏎 Quality check

  • Are your changes following our code style guidelines?
  • Are there any breaking changes in your code?
  • Does your test coverage exceed 90%?
  • Are there any erroneous console logs, debuggers or leftover code in your changes?

@danielbaud danielbaud marked this pull request as draft September 26, 2025 15:57
@osulzhenko osulzhenko added the work in progress Signals not finished work label Oct 9, 2025
@osulzhenko
Copy link
Collaborator

@danielbaud any updates on this one?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

work in progress Signals not finished work

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants