New Adapter: Nativery #4223

przemkaczmarek · 2025-09-30T15:02:07Z

🔧 Type of changes

new bid adapter

✨ What's the context?

AntoxaAntoxic · 2025-10-06T10:07:21Z

src/main/resources/bidder-config/nativery.yaml

+        - video
+        - native
+      supported-vendors: []
+      vendor-id: 0


AntoxaAntoxic · 2025-10-06T10:07:46Z

src/main/resources/bidder-config/nativery.yaml

+        - banner
+        - video
+        - native
+      supported-vendors: []


leave it just as supported-vendors:

AntoxaAntoxic · 2025-10-06T10:08:50Z

src/main/java/org/prebid/server/spring/config/bidder/NativeryBidderConfiguration.java

+    BidderDeps nativeryBidderDeps(BidderConfigurationProperties nativeryConfigurationProperties,
+                               @NotBlank @Value("${external-url}") String externalUrl,
+                               JacksonMapper mapper) {


please format

AntoxaAntoxic · 2025-10-06T10:10:33Z

src/main/java/org/prebid/server/bidder/nativery/NativeryBidder.java

+        return mapper.mapper().convertValue(root, ExtRequest.class);
+    }
+
+    private boolean isAmpRequest(BidRequest request) {


fix the methods order

AntoxaAntoxic · 2025-10-06T10:40:05Z

src/main/java/org/prebid/server/bidder/nativery/NativeryBidder.java

+        for (Imp imp : request.getImp()) {
+            try {
+                final ExtImpNativery extImp = parseImpExt(imp);
+                if (widgetId == null && extImp != null && StringUtils.isNotBlank(extImp.getWidgetId())) {


extImp cannot be null at this stage

AntoxaAntoxic · 2025-10-06T10:57:32Z

src/main/java/org/prebid/server/bidder/nativery/NativeryBidder.java

+            final BidRequest singleImpRequest = request.toBuilder()
+                    .imp(Collections.singletonList(imp))
+                    .ext(updatedExt)
+                    .cur(Collections.singletonList(DEFAULT_CURRENCY))


why is this change needed? I don't this in the Go version

AntoxaAntoxic · 2025-10-06T11:04:21Z

src/main/java/org/prebid/server/bidder/nativery/NativeryBidder.java

+        if (httpCall.getResponse() != null && httpCall.getResponse().getStatusCode() == 204) {
+            final MultiMap headers = httpCall.getResponse().getHeaders();
+            final String nativeryErr = headers != null ? headers.get(NATIVERY_ERROR_HEADER) : null;
+            if (StringUtils.isNotBlank(nativeryErr)) {
+                return Result.withError(BidderError.badInput("Nativery Error: " + nativeryErr + "."));
+            }
+            return Result.withError(BidderError.badServerResponse("No Content"));
+        }


Unfortunately this isn't going to work because the 204 status code is check before calling makeBids in the core, so probably we won't support this weird error-header approach

@CTMBNara what do you think?

Y, it won't work

src/main/java/org/prebid/server/bidder/nativery/NativeryBidder.java

AntoxaAntoxic · 2025-10-06T11:15:50Z

src/main/java/org/prebid/server/bidder/nativery/NativeryBidder.java

+
+    private BidderBid resolveBidderBid(Bid bid, String currency, List<BidderError> errors) {
+        try {
+            final ObjectNode nativeryExt = extractNativeryExt(bid.getExt());


let's create a separate BidExtNativery object and deserialize with the object mapper, because that manual conversion feels bad

AntoxaAntoxic · 2025-10-06T11:19:39Z

src/main/java/org/prebid/server/bidder/nativery/NativeryBidder.java

+    private ObjectNode extractNativeryExt(ObjectNode bidExt) {
+        if (bidExt == null) {
+            throw new PreBidException("missing bid.ext");
+        }
+        final JsonNode node = bidExt.get("nativery");
+        if (!(node instanceof ObjectNode nativeryNode)) {
+            throw new PreBidException("missing bid.ext.nativery");
+        }
+        return nativeryNode;
+    }


Replace with a simple Optional chain

AntoxaAntoxic · 2025-10-14T10:25:57Z

src/main/java/org/prebid/server/bidder/nativery/NativeryBidder.java

+            return Result.of(Collections.emptyList(), errors);
+        }
+
+        // 🟢 Zmienione — zamieniamy ExtRequest na ObjectNode


please remove the comments

AntoxaAntoxic · 2025-10-14T10:26:53Z

src/main/java/org/prebid/server/bidder/nativery/NativeryBidder.java

+        }
+
+        if (validImps.isEmpty()) {
+            return Result.of(Collections.emptyList(), errors);


Result.withErrors(errors)

AntoxaAntoxic · 2025-10-14T10:27:57Z

src/main/java/org/prebid/server/bidder/nativery/NativeryBidder.java

+        final ObjectNode originalExt = request.getExt() != null
+                ? mapper.mapper().convertValue(request.getExt(), ObjectNode.class)
+                : null;


it's not necessary to serialize ExtRequest object into the ObjectNode, because ExtRequest is a FlexibleExtension

AntoxaAntoxic · 2025-10-14T10:31:07Z

src/main/java/org/prebid/server/bidder/nativery/NativeryBidder.java

+            final ExtPrebid<?, ExtImpNativery> ext =
+                    mapper.mapper().convertValue(imp.getExt(), NATIVERY_EXT_TYPE_REFERENCE);
+            return ext != null ? ext.getBidder() : null;


imp.ext can't be null at this stage, so it can't be deserialized into null

AntoxaAntoxic · 2025-10-14T10:32:27Z

src/main/java/org/prebid/server/bidder/nativery/NativeryBidder.java

+    private ExtRequest buildRequestExtWithNativery(ObjectNode originalExt, boolean isAmp, String widgetId) {
+        final ObjectNode root = originalExt != null
+                ? originalExt.deepCopy()
+                : mapper.mapper().createObjectNode();
+
+        final ObjectNode nativeryNode = root.with("nativery");
+
+        nativeryNode.put("isAmp", isAmp);
+        if (widgetId != null) {
+            nativeryNode.put("widgetId", widgetId);
+        }
+
+        return mapper.mapper().convertValue(root, ExtRequest.class);
+    }


please use ExtRequest and FlexibleExtension capabilities

src/main/java/org/prebid/server/bidder/nativery/NativeryBidder.java

AntoxaAntoxic · 2025-10-14T10:33:55Z

src/main/java/org/prebid/server/bidder/nativery/NativeryBidder.java

+
+    private BidderBid resolveBidderBid(Bid bid, String currency, List<BidderError> errors) {
+        try {
+            final ObjectNode nativeryExt = extractNativeryExt(bid.getExt());


src/main/java/org/prebid/server/bidder/nativery/NativeryBidder.java

CTMBNara · 2025-10-28T13:24:37Z

src/main/java/org/prebid/server/bidder/nativery/NativeryBidder.java

+        if (httpCall.getResponse() != null && httpCall.getResponse().getStatusCode() == 204) {
+            final MultiMap headers = httpCall.getResponse().getHeaders();
+            final String nativeryErr = headers != null ? headers.get(NATIVERY_ERROR_HEADER) : null;
+            if (StringUtils.isNotBlank(nativeryErr)) {
+                return Result.withError(BidderError.badInput("Nativery Error: " + nativeryErr + "."));
+            }
+            return Result.withError(BidderError.badServerResponse("No Content"));
+        }


Y, it won't work

src/main/java/org/prebid/server/bidder/nativery/NativeryBidder.java

CTMBNara · 2025-10-30T10:28:30Z

src/main/java/org/prebid/server/bidder/nativery/NativeryBidder.java

+        final var response = httpCall.getResponse();
+        if (response == null || StringUtils.isBlank(response.getBody())) {
+            return Result.withError(BidderError.badServerResponse("Empty response"));
+        }


No need for this check

CTMBNara · 2025-10-30T10:31:18Z

src/main/java/org/prebid/server/bidder/nativery/NativeryBidder.java

+            final List<String> advDomains = ListUtils.defaultIfNull(
+                    nativeryExt.getBidAdvDomains(), Collections.emptyList());


Sorry, I made a typo and recommended the wrong method. Use ListUtils.emptyIfNull() directly.

CTMBNara · 2025-10-30T10:32:04Z

src/main/java/org/prebid/server/bidder/nativery/NativeryBidder.java

+    private static String mediaTypeString(BidType type) {
+        return switch (type) {
+            case banner -> type.getName();
+            case video -> type.getName();
+            case xNative -> type.getName();
+            default -> throw new IllegalStateException("Unexpected value: " + type.getName());
+        };
+    }


Remove this method and use type.getName instead

CTMBNara · 2025-10-30T10:32:56Z

src/main/java/org/prebid/server/bidder/nativery/NativeryBidder.java

+        final List<String> safeAdvDomains = Optional.ofNullable(advDomains)
+                .orElse(Collections.emptyList());


advDomains can't be null

CTMBNara · 2025-10-30T10:34:45Z

src/main/java/org/prebid/server/proto/openrtb/ext/request/nativery/BidExtNativery.java

+    @JsonProperty("bid_ad_media_type")
+    String bidAdMediaType;
+
+    @JsonProperty("bid_adv_domains")
+    List<String> bidAdvDomains;


No need for @JsonProperty. Our objectMapper uses snake-case by default

CTMBNara · 2025-10-30T10:37:49Z

src/test/java/org/prebid/server/bidder/nativery/NativeryBidderTest.java

+        final ObjectNode extNode = mapper.createObjectNode();
+        extNode.put("accountId", "acc-123");


ObjectNode -> ExtRequest. You can add custom properties to it since it is a FlexibleExtension

CTMBNara · 2025-10-30T10:38:03Z

src/test/java/org/prebid/server/bidder/nativery/NativeryBidderTest.java

+        final ObjectNode extNode = mapper.createObjectNode();
+        final ObjectNode prebidNode = mapper.createObjectNode();
+        final ObjectNode serverNode = mapper.createObjectNode();
+        serverNode.put("endpoint", Endpoint.openrtb2_amp.value());
+        prebidNode.set("server", serverNode);
+        extNode.set("prebid", prebidNode);


AntoxaAntoxic · 2025-11-06T08:48:27Z

src/main/java/org/prebid/server/bidder/nativery/NativeryBidder.java

+        final ExtRequest requestExt = bidRequest.getExt();
+        final ExtRequestPrebid prebid = requestExt != null ? requestExt.getPrebid() : null;
+        final ExtRequestPrebidServer server = prebid != null ? prebid.getServer() : null;
+        return server != null ? server.getEndpoint() : null;


please use Optional here

AntoxaAntoxic · 2025-11-06T08:54:37Z

src/main/java/org/prebid/server/bidder/nativery/NativeryBidder.java

+    public Result<List<BidderBid>> makeBids(BidderCall<BidRequest> httpCall, BidRequest bidRequest) {
+        final List<BidderError> errors = new ArrayList<>();
+
+        final var response = httpCall.getResponse();


please don't use var

AntoxaAntoxic · 2025-11-06T09:11:16Z

src/main/java/org/prebid/server/bidder/nativery/NativeryBidder.java

+    private BidExtNativery parseNativeryExt(ObjectNode bidExt) {
+        if (bidExt == null) {
+            throw new PreBidException("missing bid.ext");
+        }
+        final JsonNode node = bidExt.get("nativery");
+        if (!(node instanceof ObjectNode nativeryNode)) {
+            throw new PreBidException("missing bid.ext.nativery");
+        }
+        try {
+            return mapper.mapper().convertValue(nativeryNode, BidExtNativery.class);
+        } catch (IllegalArgumentException e) {
+            throw new PreBidException("invalid bid.ext.nativery: " + e.getMessage());
+        }
+    }


I'd simplify it to the optional chain like

return Optional.ofNullable(bidExt) .map(ext -> ext.get("nativery")) .filter(JsonNode::isObject) .map(/*convertValue*/) .orElseThrow(() -> new PreBidException("missing bid.ext.nativery"));

AntoxaAntoxic · 2025-11-06T09:20:51Z

src/test/java/org/prebid/server/bidder/nativery/NativeryBidderTest.java

+        assertThat(result.getValue())
+                .extracting(HttpRequest::getPayload)
+                .flatExtracting(BidRequest::getImp)
+                .extracting(Imp::getId)
+                .containsExactly("imp1");


the assert is missing, it should check the request.payload.impIds instead

actually you can merge this test with the makeHttpRequestsShouldMakeOneRequestPerImp

AntoxaAntoxic · 2025-11-06T09:22:48Z

src/test/java/org/prebid/server/bidder/nativery/NativeryBidderTest.java

+    public void makeHttpRequestsShouldPreserveOriginalExtFields() {
+        // given
+        final ExtRequest extRequest = ExtRequest.empty();
+        extRequest.addProperty("accountId", mapper.convertValue("acc-123", JsonNode.class));


extRequest.addProperty("accountId", TextNode.valueOf("acc-123"));

AntoxaAntoxic · 2025-11-06T09:25:08Z

src/test/java/org/prebid/server/bidder/nativery/NativeryBidderTest.java

+        final ObjectNode serverNode = mapper.createObjectNode();
+        serverNode.put("endpoint", Endpoint.openrtb2_amp.value());


there is a ExtRequestPrebidServer class that can be used

AntoxaAntoxic · 2025-11-06T09:25:30Z

src/test/java/org/prebid/server/bidder/nativery/NativeryBidderTest.java

+        final ObjectNode extNode = mapper.createObjectNode();
+        extNode.set("prebid", prebidNode);
+
+        final ExtRequest extRequest = mapper.convertValue(extNode, ExtRequest.class);


just build the ExtRequest object - no need to convert

src/test/java/org/prebid/server/bidder/nativery/NativeryBidderTest.java

AntoxaAntoxic · 2025-11-06T09:30:54Z

src/test/java/org/prebid/server/bidder/nativery/NativeryBidderTest.java

+        assertThat(result.getValue())
+                .extracting(BidderBid::getType)
+                .containsExactly(BidType.xNative);


ideally the whole BidderBid object should be checked

AntoxaAntoxic · 2025-11-06T09:31:20Z

src/test/java/org/prebid/server/bidder/nativery/NativeryBidderTest.java

+                .hasSize(1)
+                .allSatisfy(error -> {
+                    assertThat(error.getMessage())
+                            .contains("unrecognized bid_ad_media_type in response from nativery: audio");


isEqualTo

AntoxaAntoxic · 2025-11-07T08:39:05Z

src/main/java/org/prebid/server/bidder/nativery/NativeryBidder.java

+                    try {
+                        return mapper.mapper().convertValue(node, BidExtNativery.class);
+                    } catch (IllegalArgumentException e) {
+                        throw new PreBidException("invalid bid.ext.nativery: " + e.getMessage());
+                    }


please extract into a separate method

AntoxaAntoxic · 2025-11-07T08:39:38Z

src/main/java/org/prebid/server/bidder/nativery/NativeryBidder.java

+    }
+
+    private BidExtNativery parseNativeryExt(ObjectNode bidExt) {
+        return Optional.of(bidExt)


the last time there was a non-null check, why it's not here anymore?

AntoxaAntoxic · 2025-11-07T08:45:55Z

src/test/java/org/prebid/server/bidder/nativery/NativeryBidderTest.java

+        assertThat(result.getValue()).hasSize(2)
+                .extracting(HttpRequest::getPayload)
+                .extracting(BidRequest::getImp)
+                .extracting(List::size)
+                .containsOnly(1);
+        assertThat(result.getValue())
+                .extracting(HttpRequest::getPayload)
+                .flatExtracting(BidRequest::getImp)
+                .extracting(Imp::getId)
+                .containsExactlyInAnyOrder("123", "321");


This kind of check is missed

assertThat(results.getValue()).hasSize(2) .extracting(HttpRequest::getImpIds) .containsExactly(Set.of("123"), Set.of("321"));

AntoxaAntoxic · 2025-11-07T08:46:16Z

src/test/java/org/prebid/server/bidder/nativery/NativeryBidderTest.java

+        assertThat(result.getValue())
+                .extracting(BidderBid::getType)
+                .containsExactly(BidType.banner);


it's better to assert the whole BidderBid object

I can’t write:
.containsExactly(BidderBid.of(Bid.builder().impid("123").build(), video, "EUR"));

because
the production code in NativeryBidder.makeBids always overrides bid.ext, setting it to a structure like:
{
"prebid": {
"meta": {
"mediaType": ...,
"advertiserDomains": [...]
}
}
}
The expected object has ext == null, so containsExactly(...) compares the full objects and detects a difference in the bid.ext field.
To make the assertion pass, you would need to construct the expected Bid with the same ext, or narrow the assertion to only check the type.

That’s why I used:
assertThat(result.getValue())
.extracting(BidderBid::getType)
.containsExactly(BidType.banner);

(Other adapters use this approach too, for example playdigo.)

The goal of the test should be checking the bid is correct, not just a type of this bid. So narrowing the assertion might hide the potential issues. IMHO

AntoxaAntoxic · 2025-11-07T08:47:02Z

src/main/java/org/prebid/server/bidder/nativery/NativeryBidder.java

+                    try {
+                        return mapper.mapper().convertValue(node, BidExtNativery.class);
+                    } catch (IllegalArgumentException e) {
+                        throw new PreBidException("invalid bid.ext.nativery: " + e.getMessage());
+                    }


please extract into a separate method

AntoxaAntoxic · 2025-11-07T08:47:10Z

src/main/java/org/prebid/server/bidder/nativery/NativeryBidder.java

+    }
+
+    private BidExtNativery parseNativeryExt(ObjectNode bidExt) {
+        return Optional.of(bidExt)


the last time there was a non-null check, why it's not here anymore?

AntoxaAntoxic · 2025-11-14T08:50:39Z

src/test/java/org/prebid/server/bidder/nativery/NativeryBidderTest.java

+        final Bid expectedBid = Bid.builder()
+                .impid("123")
+                .ext(mapper.valueToTree(ExtPrebid.of(
+                        ExtBidPrebid.builder()
+                                .meta(org.prebid.server.proto.openrtb.ext.response.ExtBidPrebidMeta.builder()
+                                        .mediaType("banner")
+                                        .advertiserDomains(List.of())
+                                        .build())
+                                .build(),
+                        null)))
+                .build();
+
+        final BidderBid expected = BidderBid.of(expectedBid, banner, DEFAULT_CURRENCY);
+
+        assertThat(result.getErrors()).isEmpty();
+        assertThat(result.getValue()).containsExactly(expected);


please check the whole bids for other cases as well

New Adapter: Nativery

3b1abb9

przemkaczmarek self-assigned this Oct 2, 2025

przemkaczmarek added the do not port label Oct 2, 2025

przemkaczmarek requested a review from AntoxaAntoxic October 2, 2025 17:16

osulzhenko linked an issue Oct 3, 2025 that may be closed by this pull request

Port PR from PBS-Go: New Adapter: Nativery #4198

Open

AntoxaAntoxic requested changes Oct 6, 2025

View reviewed changes

przemkaczmarek added 2 commits October 11, 2025 11:40

fix comments

c9ceec1

fix test

f92d15f

AntoxaAntoxic reviewed Oct 14, 2025

View reviewed changes

fix comments

a9e734f

CTMBNara requested changes Oct 28, 2025

View reviewed changes

fix comments

3a979e6

CTMBNara requested changes Oct 30, 2025

View reviewed changes

przemkaczmarek added 2 commits November 3, 2025 15:47

fix comments

94a24ca

fix test makeHttpRequestsShouldSetExtWithAmpTrue

1165db7

And1sS requested a review from AntoxaAntoxic November 5, 2025 11:56

AntoxaAntoxic requested changes Nov 6, 2025

View reviewed changes

fix comments

869eca1

AntoxaAntoxic requested changes Nov 7, 2025

View reviewed changes

fix tests

b99820d

AntoxaAntoxic reviewed Nov 14, 2025

View reviewed changes

fix comments

b98d69a

		final List<String> advDomains = ListUtils.defaultIfNull(
		nativeryExt.getBidAdvDomains(), Collections.emptyList());

		final List<String> safeAdvDomains = Optional.ofNullable(advDomains)
		.orElse(Collections.emptyList());

		final ObjectNode extNode = mapper.createObjectNode();
		extNode.put("accountId", "acc-123");

		final ObjectNode serverNode = mapper.createObjectNode();
		serverNode.put("endpoint", Endpoint.openrtb2_amp.value());

New Adapter: Nativery #4223

Are you sure you want to change the base?

New Adapter: Nativery #4223

Uh oh!

Conversation

przemkaczmarek commented Sep 30, 2025

🔧 Type of changes

✨ What's the context?

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

AntoxaAntoxic Nov 14, 2025 •

edited

Loading