Skip to content
Open
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

import lombok.Value;

import javax.validation.constraints.NotNull;
import jakarta.validation.constraints.NotNull;

@Value(staticConstructor = "of")
public class Id {
Expand Down
8 changes: 1 addition & 7 deletions extra/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,6 @@
<!-- Project production dependency versions -->
<spring.boot.version>3.5.5</spring.boot.version>
<vertx.version>4.5.20</vertx.version>
<validation-api.version>2.0.1.Final</validation-api.version>
<commons.collections.version>4.4</commons.collections.version>
<commons.compress.version>1.27.1</commons.compress.version>
<commons-math3.version>3.6.1</commons-math3.version>
Expand All @@ -52,7 +51,7 @@
<iabtcf.version>2.0.10</iabtcf.version>
<gpp-encoder.version>3.2.4</gpp-encoder.version>
<maxmind-client.version>4.2.1</maxmind-client.version>
<protobuf.version>3.25.6</protobuf.version>
<protobuf.version>4.32.1</protobuf.version>
<protoc.version>${protobuf.version}</protoc.version>
<json-logic.version>1.0.9</json-logic.version>
<aws.awssdk.version>2.31.22</aws.awssdk.version>
Expand Down Expand Up @@ -111,11 +110,6 @@
<artifactId>wiremock-jetty12</artifactId>
<version>${wiremock.version}</version>
</dependency>
<dependency>
<groupId>javax.validation</groupId>
<artifactId>validation-api</artifactId>
<version>${validation-api.version}</version>
</dependency>
<dependency>
<groupId>com.ongres.scram</groupId>
<artifactId>client</artifactId>
Expand Down
4 changes: 2 additions & 2 deletions pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -41,8 +41,8 @@
<artifactId>jakarta.annotation-api</artifactId>
</dependency>
<dependency>
<groupId>javax.validation</groupId>
<artifactId>validation-api</artifactId>
<groupId>jakarta.validation</groupId>
<artifactId>jakarta.validation-api</artifactId>
</dependency>
<dependency>
<groupId>org.hibernate.validator</groupId>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
import com.fasterxml.jackson.core.type.TypeReference;
import com.fasterxml.jackson.databind.JsonNode;
import com.fasterxml.jackson.databind.node.ObjectNode;
import com.google.common.base.Strings;
import com.iab.openrtb.request.App;
import com.iab.openrtb.request.BidRequest;
import com.iab.openrtb.request.Imp;
Expand All @@ -13,6 +12,7 @@
import com.iab.openrtb.response.SeatBid;
import io.vertx.core.MultiMap;
import org.apache.commons.collections4.CollectionUtils;
import org.apache.commons.lang3.StringUtils;
import org.prebid.server.bidder.Bidder;
import org.prebid.server.bidder.model.BidderBid;
import org.prebid.server.bidder.model.BidderCall;
Expand Down Expand Up @@ -65,7 +65,7 @@ public Result<List<HttpRequest<BidRequest>>> makeHttpRequests(BidRequest bidRequ
if (!isImpValid(bidRequest.getSite(), bidRequest.getApp(), impExt)) {
continue;
}
if (Strings.isNullOrEmpty(placementId) && !Strings.isNullOrEmpty(impExt.getPlacementId())) {
if (StringUtils.isBlank(placementId) && StringUtils.isNotBlank(impExt.getPlacementId())) {
placementId = impExt.getPlacementId();
}

Expand Down Expand Up @@ -93,7 +93,7 @@ private ExtImpConsumable parseImpExt(Imp imp) {
}

private boolean isImpValid(Site site, App app, ExtImpConsumable impExt) {
return (app != null && !Strings.isNullOrEmpty(impExt.getPlacementId()))
return (app != null && StringUtils.isNotBlank(impExt.getPlacementId()))
|| (site != null && impExt.getSiteId() != 0 && impExt.getNetworkId() != 0 && impExt.getUnitId() != 0);

}
Expand All @@ -103,7 +103,7 @@ private BidRequest modifyBidRequest(BidRequest bidRequest, List<Imp> imps) {
}

private String constructUri(String placementId) {
final String uri = Strings.isNullOrEmpty(placementId) ? SITE_URI_PATH : (APP_URI_PATH + placementId);
final String uri = StringUtils.isBlank(placementId) ? SITE_URI_PATH : (APP_URI_PATH + placementId);
return this.endpointUrl + uri;
}

Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
package org.prebid.server.protobuf.request;

import com.google.protobuf.Extension;
import com.google.protobuf.ExtensionLite;
import com.google.protobuf.Message;

/**
Expand All @@ -10,5 +10,5 @@ public interface ProtobufForwardExtensionMapper<ContainingType extends Message,

ToType map(FromType fromType);

Extension<ContainingType, ToType> extensionDescriptor();
ExtensionLite<ContainingType, ToType> extensionDescriptor();
}
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
package org.prebid.server.protobuf.response;

import com.google.protobuf.Extension;
import com.google.protobuf.ExtensionLite;
import com.google.protobuf.Message;

/**
Expand All @@ -10,5 +10,5 @@ public interface ProtobufBackwardExtensionMapper<ContainingType extends Message,

ToType map(FromType fromType);

Extension<ContainingType, FromType> extensionDescriptor();
ExtensionLite<ContainingType, FromType> extensionDescriptor();
}
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

import com.fasterxml.jackson.core.JsonProcessingException;
import com.fasterxml.jackson.databind.ObjectMapper;
import com.google.protobuf.GeneratedMessageV3;
import com.google.protobuf.GeneratedMessage;
import com.iab.openrtb.response.Asset;
import com.iab.openrtb.response.Bid;
import com.iab.openrtb.response.BidResponse;
Expand Down Expand Up @@ -248,7 +248,7 @@ public static ProtobufMapper<OpenRtb.NativeResponse.Asset.Video, VideoObject> na
.build();
}

private static <ContainingType extends GeneratedMessageV3.ExtendableMessage<ContainingType>, FromType, ToType>
private static <ContainingType extends GeneratedMessage.ExtendableMessage<ContainingType>, FromType, ToType>
ToType extractExtension(
ProtobufBackwardExtensionMapper<ContainingType, FromType, ToType> mapper, ContainingType value) {

Expand Down
10 changes: 5 additions & 5 deletions src/main/java/org/prebid/server/settings/SettingsCache.java
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,9 @@
import com.github.benmanes.caffeine.cache.Expiry;
import org.apache.commons.collections4.MapUtils;
import org.apache.commons.lang3.ObjectUtils;
import org.checkerframework.checker.index.qual.NonNegative;
import org.prebid.server.settings.model.StoredItem;

import jakarta.validation.constraints.PositiveOrZero;
import java.util.Collections;
import java.util.HashSet;
import java.util.List;
Expand Down Expand Up @@ -108,12 +108,12 @@ public long expireAfterCreate(K key, V value, long currentTime) {
}

@Override
public long expireAfterUpdate(K key, V value, long currentTime, @NonNegative long currentDuration) {
public long expireAfterUpdate(K key, V value, long currentTime, @PositiveOrZero long currentDuration) {
return expireAfterNanos;
}

@Override
public long expireAfterRead(K key, V value, long currentTime, @NonNegative long currentDuration) {
public long expireAfterRead(K key, V value, long currentTime, @PositiveOrZero long currentDuration) {
return currentDuration;
}
}
Expand All @@ -134,12 +134,12 @@ public long expireAfterCreate(K key, V value, long currentTime) {
}

@Override
public long expireAfterUpdate(K key, V value, long currentTime, @NonNegative long currentDuration) {
public long expireAfterUpdate(K key, V value, long currentTime, @PositiveOrZero long currentDuration) {
return baseExpiry.expireAfterUpdate(key, value, currentTime, currentDuration) + jitter();
}

@Override
public long expireAfterRead(K key, V value, long currentTime, @NonNegative long currentDuration) {
public long expireAfterRead(K key, V value, long currentTime, @PositiveOrZero long currentDuration) {
return baseExpiry.expireAfterRead(key, value, currentTime, currentDuration);
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -51,9 +51,9 @@
import software.amazon.awssdk.regions.Region;
import software.amazon.awssdk.services.s3.S3AsyncClient;

import javax.validation.constraints.Min;
import javax.validation.constraints.NotBlank;
import javax.validation.constraints.NotNull;
import jakarta.validation.constraints.Min;
import jakarta.validation.constraints.NotBlank;
import jakarta.validation.constraints.NotNull;
import java.net.URI;
import java.net.URISyntaxException;
import java.time.Clock;
Expand Down Expand Up @@ -259,6 +259,9 @@ static class S3SettingsConfiguration {

@Component
@ConfigurationProperties(prefix = "settings.s3")
@ConditionalOnProperty(
prefix = "settings.s3",
name = {"accounts-dir", "stored-imps-dir", "stored-requests-dir"})
@Validated
@Data
@NoArgsConstructor
Expand Down Expand Up @@ -294,7 +297,7 @@ private boolean useStaticCredentials() {
@NotBlank
private String bucket;

@NotBlank
@NotNull
private Boolean forcePathStyle;

@NotBlank
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
import org.springframework.context.annotation.Configuration;
import org.springframework.context.annotation.PropertySource;

import javax.validation.constraints.NotBlank;
import jakarta.validation.constraints.NotBlank;

@Configuration
@PropertySource(value = "classpath:/bidder-config/aso.yaml", factory = YamlPropertySourceFactory.class)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
import org.springframework.context.annotation.Configuration;
import org.springframework.context.annotation.PropertySource;

import javax.validation.constraints.NotBlank;
import jakarta.validation.constraints.NotBlank;

@Configuration
@PropertySource(value = "classpath:/bidder-config/bidtheatre.yaml", factory = YamlPropertySourceFactory.class)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
import org.springframework.context.annotation.Configuration;
import org.springframework.context.annotation.PropertySource;

import javax.validation.constraints.NotBlank;
import jakarta.validation.constraints.NotBlank;

@Configuration
@PropertySource(value = "classpath:/bidder-config/bwx.yaml", factory = YamlPropertySourceFactory.class)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
import org.springframework.context.annotation.Configuration;
import org.springframework.context.annotation.PropertySource;

import javax.validation.constraints.NotBlank;
import jakarta.validation.constraints.NotBlank;

@Configuration
@PropertySource(value = "classpath:/bidder-config/definemedia.yaml", factory = YamlPropertySourceFactory.class)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
import org.springframework.context.annotation.Configuration;
import org.springframework.context.annotation.PropertySource;

import javax.validation.constraints.NotBlank;
import jakarta.validation.constraints.NotBlank;

@Configuration
@PropertySource(value = "classpath:/bidder-config/exco.yaml", factory = YamlPropertySourceFactory.class)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
import org.springframework.context.annotation.Configuration;
import org.springframework.context.annotation.PropertySource;

import javax.validation.constraints.NotBlank;
import jakarta.validation.constraints.NotBlank;

@Configuration
@PropertySource(value = "classpath:/bidder-config/loopme.yaml", factory = YamlPropertySourceFactory.class)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
import org.springframework.context.annotation.Configuration;
import org.springframework.context.annotation.PropertySource;

import javax.validation.constraints.NotBlank;
import jakarta.validation.constraints.NotBlank;

@Configuration
@PropertySource(value = "classpath:/bidder-config/mabidder.yaml", factory = YamlPropertySourceFactory.class)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
import org.springframework.context.annotation.Configuration;
import org.springframework.context.annotation.PropertySource;

import javax.validation.constraints.NotBlank;
import jakarta.validation.constraints.NotBlank;

@Configuration
@PropertySource(value = "classpath:/bidder-config/mobkoi.yaml", factory = YamlPropertySourceFactory.class)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
import org.springframework.context.annotation.Configuration;
import org.springframework.context.annotation.PropertySource;

import javax.validation.constraints.NotBlank;
import jakarta.validation.constraints.NotBlank;

@Configuration
@PropertySource(value = "classpath:/bidder-config/ownadx.yaml", factory = YamlPropertySourceFactory.class)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
import org.springframework.context.annotation.Configuration;
import org.springframework.context.annotation.PropertySource;

import javax.validation.constraints.NotBlank;
import jakarta.validation.constraints.NotBlank;

@Configuration
@PropertySource(value = "classpath:/bidder-config/roulax.yaml", factory = YamlPropertySourceFactory.class)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
import org.springframework.context.annotation.Configuration;
import org.springframework.context.annotation.PropertySource;

import javax.validation.constraints.NotBlank;
import jakarta.validation.constraints.NotBlank;

@Configuration
@PropertySource(value = "classpath:/bidder-config/smrtconnect.yaml", factory = YamlPropertySourceFactory.class)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
import org.springframework.context.annotation.Configuration;
import org.springframework.context.annotation.PropertySource;

import javax.validation.constraints.NotBlank;
import jakarta.validation.constraints.NotBlank;

@Configuration
@PropertySource(value = "classpath:/bidder-config/theadx.yaml", factory = YamlPropertySourceFactory.class)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
import org.springframework.context.annotation.Configuration;
import org.springframework.context.annotation.PropertySource;

import javax.validation.constraints.NotBlank;
import jakarta.validation.constraints.NotBlank;

@Configuration
@PropertySource(value = "classpath:/bidder-config/tradplus.yaml", factory = YamlPropertySourceFactory.class)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
import org.springframework.context.annotation.Configuration;
import org.springframework.context.annotation.PropertySource;

import javax.validation.constraints.NotBlank;
import jakarta.validation.constraints.NotBlank;

@Configuration
@PropertySource(value = "classpath:/bidder-config/trustedstack.yaml", factory = YamlPropertySourceFactory.class)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
import org.springframework.context.annotation.Configuration;
import org.springframework.context.annotation.PropertySource;

import javax.validation.constraints.NotBlank;
import jakarta.validation.constraints.NotBlank;

@Configuration
@PropertySource(value = "classpath:/bidder-config/zmaticoo.yaml", factory = YamlPropertySourceFactory.class)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@
import lombok.NoArgsConstructor;
import org.springframework.validation.annotation.Validated;

import javax.validation.constraints.Min;
import javax.validation.constraints.NotNull;
import jakarta.validation.constraints.Min;
import jakarta.validation.constraints.NotNull;

@Data
@Validated
Expand Down
Loading