Nextmillennium: New fields and adapter version update #4246
+106
−30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AntoxaAntoxic
requested changes
Oct 24, 2025
Comment on lines
+159
to
+160
| NextMillenniumExtBidder.of( | ||
| nmmFlags, extImp.getAdSlots(), extImp.getAllowedAds(), null, null)); |
There was a problem hiding this comment.
If I understand the changes in Go correctly adslots and allowedads shouldn't be added to the imp.ext
There was a problem hiding this comment.
and please, create a separate static constructor of with the only nmmFlags parameter
Comment on lines
+183
to
+184
| nmmFlags, extImp.getAdSlots(), extImp.getAllowedAds(), NM_ADAPTER_VERSION, | ||
| versionProvider.getNameVersionRecord())); |
There was a problem hiding this comment.
please chop the whole parameter list down
| request -> request.app(App.builder().domain("appDomain").build()), | ||
| givenImpWithExt(identity(), ExtImpNextMillennium.of(null, "group1")), | ||
| givenImpWithExt(identity(), ExtImpNextMillennium.of(null, "group2"))); | ||
| givenImpWithExt(identity(), ExtImpNextMillennium.of(null, "group1", null, null)), |
There was a problem hiding this comment.
I'd prefer extracting ExtImpNextMillennium.of(null, "group1", null, null) and ExtImpNextMillennium.of("placement1", "group1", null, null) into separate methods in order not to pass nulls everywhere
Comment on lines
+212
to
+222
| final ObjectNode requestExtNode = mapper.valueToTree(actualRequest.getExt()); | ||
| assertThat(requestExtNode.at("/nextMillennium/adSlots/0").asText()).isEqualTo("slot1"); | ||
| assertThat(requestExtNode.at("/nextMillennium/adSlots/1").asText()).isEqualTo("slot2"); | ||
| assertThat(requestExtNode.at("/nextMillennium/allowedAds/0").asText()).isEqualTo("ad1"); | ||
| assertThat(requestExtNode.at("/nextMillennium/allowedAds/1").asText()).isEqualTo("ad2"); | ||
|
|
||
| final ObjectNode impExtNode = (ObjectNode) actualRequest.getImp().getFirst().getExt(); | ||
| assertThat(impExtNode.at("/nextMillennium/adSlots/0").asText()).isEqualTo("slot1"); | ||
| assertThat(impExtNode.at("/nextMillennium/adSlots/1").asText()).isEqualTo("slot2"); | ||
| assertThat(impExtNode.at("/nextMillennium/allowedAds/0").asText()).isEqualTo("ad1"); | ||
| assertThat(impExtNode.at("/nextMillennium/allowedAds/1").asText()).isEqualTo("ad2"); |
There was a problem hiding this comment.
I'd prefer using extracting approach like everywhere else in the test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔧 Type of changes
✨ What's the context?
#4234