Skip to content

Conversation

@MakisH
Copy link
Member

@MakisH MakisH commented Jul 2, 2024

Our Nutils cases implicitly depend on NumPy 1. NumPy 2 was recently released, which breaks such installations. This adds a numpy >1, <2 in all requirements.txt that also specify Nutils.

This brings up the issue that we should add requirements.txt for all other Python examples as well (in a separate PR). See #547

Checklist:

  • I added a summary of any user-facing changes (compared to the last release) in the changelog-entries/<PRnumber>.md. -> N/A
  • I will remember to squash-and-merge, providing a useful summary of the changes of this PR.

Copy link
Member

@IshaanDesai IshaanDesai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but a cleaner solution would be to restrict the NumPy version in the Python bindings dependencies, and release a new version of the bindings. Adding the line in every tutorial is error prone and will increase maintainability.

pip would still update NumPy, even if we restrict it to a lower version at the bindings stage

@MakisH MakisH merged commit d38e4d1 into precice:develop Jul 4, 2024
@MakisH MakisH deleted the numpy2 branch July 4, 2024 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants