Skip to content

Conversation

@IshaanDesai
Copy link
Member

@IshaanDesai IshaanDesai commented Oct 21, 2025

In the macro-dumux participant of the two-scale heat conduction tutorial, the checkpointing is currently done manually. precice/dumux-adapter#58 introduces checkpointing functionality in the DuMuX adapter. This PR changes macro-dumux to use this functionality.

Note: Not to be merged before precice/dumux-adapter#58. This PR is for testing purposes.

Checklist:

  • I added a summary of any user-facing changes (compared to the last release) in the changelog-entries/<PRnumber>.md.
  • I will remember to squash-and-merge, providing a useful summary of the changes of this PR.

Copy link
Member Author

@IshaanDesai IshaanDesai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some open questions still.

@IshaanDesai
Copy link
Member Author

The tutorial case runs successfully with the changes in the adapter. The result look reasonable:

image

@IshaanDesai IshaanDesai marked this pull request as ready for review October 23, 2025 08:04
Copy link
Collaborator

@mathiskelm mathiskelm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the corresponding changes.

@IshaanDesai IshaanDesai merged commit 5fcf9c6 into precice:develop Oct 23, 2025
1 check passed
@IshaanDesai IshaanDesai deleted the checkpointing-dumux branch October 23, 2025 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants