chore(ci): Advance Velox #26385

tanjialiang · 2025-10-21T19:11:24Z

== NO RELEASE NOTE ==

sourcery-ai · 2025-10-21T19:11:56Z

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR advances the Velox submodule to its latest commit and updates associated build definitions and compatibility tweaks in the Presto native execution module.

File-Level Changes

Change	Details	Files
Updated Velox submodule reference	Bumped the Velox SHA in .gitmodules Ran submodule sync and updated git pointer Committed the new Velox version	`presto-native-execution/velox`
Adjusted build and workspace configurations	Updated WORKSPACE to use the new Velox release Modified BUILD rules to reflect API surface changes Re-generated build artifacts for the updated submodule	`presto-native-execution/velox/WORKSPACE` `presto-native-execution/velox/BUILD`
Resolved API compatibility changes	Refactored calls to renamed Velox methods Updated import paths for moved modules Suppressed or handled new deprecation warnings	`presto-native-execution/velox/** (various source files)`

Tips and commands

Interacting with Sourcery

Trigger a new review: Comment @sourcery-ai review on the pull request.
Continue discussions: Reply directly to Sourcery's review comments.
Generate a GitHub issue from a review comment: Ask Sourcery to create an
issue from a review comment by replying to it. You can also reply to a
review comment with @sourcery-ai issue to create an issue from it.
Generate a pull request title: Write @sourcery-ai anywhere in the pull
request title to generate a title at any time. You can also comment
@sourcery-ai title on the pull request to (re-)generate the title at any time.
Generate a pull request summary: Write @sourcery-ai summary anywhere in
the pull request body to generate a PR summary at any time exactly where you
want it. You can also comment @sourcery-ai summary on the pull request to
(re-)generate the summary at any time.
Generate reviewer's guide: Comment @sourcery-ai guide on the pull
request to (re-)generate the reviewer's guide at any time.
Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
pull request to resolve all Sourcery comments. Useful if you've already
addressed all the comments and don't want to see them anymore.
Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
request to dismiss all existing Sourcery reviews. Especially useful if you
want to start fresh with a new review - don't forget to comment
@sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

Enable or disable review features such as the Sourcery-generated pull request
summary, the reviewer's guide, and others.
Change the review language.
Add, remove or edit custom review instructions.
Adjust other review settings.

Getting Help

Contact our support team for questions or feedback.
Visit our documentation for detailed guides and information.
Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

sourcery-ai

Hey there - I've reviewed your changes and they look great!

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

aditi-pandit

@tanjialiang : Please fix build errors

/__w/presto/presto/presto-native-execution/presto_cpp/main/SessionProperties.cpp: In constructor 'facebook::presto::SessionProperties::SessionProperties()':
/__w/presto/presto/presto-native-execution/presto_cpp/main/SessionProperties.cpp:574:20: error: 'kRowSizeTrackingEnabled' is not a member of 'facebook::velox::core::QueryConfig'
  574 |       QueryConfig::kRowSizeTrackingEnabled,
      |                    ^~~~~~~~~~~~~~~~~~~~~~~
/__w/presto/presto/presto-native-execution/presto_cpp/main/SessionProperties.cpp:575:24: error: 'class facebook::velox::core::QueryConfig' has no member named 'rowSizeTrackingEnabled'; did you mean 'rowSizeTrackingMode'?
  575 |       std::to_string(c.rowSizeTrackingEnabled()));
      |                        ^~~~~~~~~~~~~~~~~~~~~~
      |                        rowSizeTrackingMode
At global scope:
cc1plus: note: unrecognized command-line option '-Wno-nullability-completeness' may have been intended to silence earlier diagnostics
[1142/1299] Building CXX object presto_cpp/main/CMakeFiles/presto_server_remote_function.dir/JsonSignatureParser.cpp.o
[1143/1299] Building CXX object presto_cpp/main/CMakeFiles/presto_server_remote_function.dir/RemoteFunctionRegisterer.cpp.o
[1144/1299] Building CXX object presto_cpp/main/operators/tests/CMakeFiles/presto_operators_plan_builder.dir/PlanBuilder.cpp.o

unidevel · 2025-10-22T13:52:26Z

Due to the change in facebookincubator/velox@a52307a54, we have to update scripts related to github_checkout (it removed cd)

czentgr · 2025-10-22T14:52:45Z

@unidevel @tanjialiang I'm making another PR to fix the setup scripts. We can either put all of this into a single PR or into two PRs (preferred) that goes after this one.

czentgr · 2025-10-22T18:36:42Z

We can merge this as a companion PR to the advance of Velox PR: #26406

simoneves · 2025-10-22T22:17:10Z

Not sure if this is the right place to ask for this, but...

We hit an issue using latest Velox with Presto, because of the recent rowSizeTrackingEnabled/rowSizeTrackingMode change (facebookincubator/velox#15111) and although they provided the ability to set VELOX_ENABLE_BACKWARD_COMPATIBILITY to bridge the change, there is no option in the Presto build to invoke this.

I would like to propose you add this as a Presto build option and plumb it down to the Velox build, as it would help workaround situations like this. They have used that flag several times in the past to bridge changes, and I'm sure they will again in the future, so I was surprised to find that it wasn't exposed in the Presto build.

mbasmanova · 2025-10-22T22:35:23Z

We intentionally do not want to make this flag available in Prestissimo repo to ensure that Prestissimo code is updated quickly to stop using deprecated APIs.

simoneves · 2025-10-22T22:44:37Z

We intentionally do not want to make this flag available in Prestissimo repo to ensure that Prestissimo code is updated quickly to stop using deprecated APIs.

Fair enough. Thank you. We have a workaround for now, so we look forward to the Presto-side fix.

aditi-pandit · 2025-10-23T19:23:29Z

@tanjialiang : Am curious about the status of this PR. We haven't updated Velox in few days now.

@amitkdutta

amitkdutta · 2025-10-23T21:43:36Z

@HuamengJiang @tanjialiang kRowSizeTrackingEnabled is now an enum. We need to update Prestissimo appropriately to move Velox version.

tanjialiang · 2025-10-23T21:55:32Z

We can merge this as a companion PR to the advance of Velox PR: #26406

Do you want me to include the PR in this PR and update together? Or how do you want to do it? Let me know.

czentgr · 2025-10-23T22:14:31Z

@tanjialiang my PR does not depend on the changes here but is required once this PR merges. Ahh but it turns out you need my PR to get the CI green here (I have thesetup-macos.sh changes).
My PR is about to be merged once its CI is green so we should be good to go here as well soon.

## Description A recent change in Velox changed what the current directory is after github_checkout. This breaks building the PrestoC++ dependencies. The refactor removes github cloning and instead pulls released tar.gz images of the source code. This also increases the download speed. This is a companion PR to #26385 ``` == NO RELEASE NOTE == ```

amitkdutta

Thanks @tanjialiang

aditi-pandit

Thanks @tanjialiang

aditi-pandit · 2025-10-24T18:13:32Z

presto-native-execution/presto_cpp/main/SessionProperties.cpp

-      QueryConfig::kRowSizeTrackingEnabled,
-      std::to_string(c.rowSizeTrackingEnabled()));
+      QueryConfig::kRowSizeTrackingMode,
+      std::to_string(static_cast<int32_t>(c.rowSizeTrackingMode())));


@tanjialiang : This is just going to show 1, 2, 3 and not the string versions of the enums. We should ask Velox team to expose the string names of the enums (they have a macro for it) which we can use here.

facebookincubator/velox#15111 (review)

yeah we can do a followup on this

aditi-pandit · 2025-10-24T18:15:20Z

@tdcmeehan : Please can you review. Don't know why committers got tagged here.

aditi-pandit · 2025-10-24T18:19:20Z

Tim and Christian are working on the Presto Native pre-commit hook. It will take an hour or two to resolve. We can submit after.

@amitkdutta @tanjialiang

aditi-pandit

Thanks @tanjialiang

tanjialiang requested review from a team as code owners October 21, 2025 19:11

prestodb-ci added the from:Meta PR from Meta label Oct 21, 2025

zacw7 previously approved these changes Oct 21, 2025

View reviewed changes

sourcery-ai bot reviewed Oct 21, 2025

View reviewed changes

aditi-pandit requested changes Oct 21, 2025

View reviewed changes

czentgr mentioned this pull request Oct 22, 2025

build(native): Refactor setup scripts #26406

Merged

7 tasks

tanjialiang dismissed zacw7’s stale review via faff178 October 23, 2025 21:52

tanjialiang force-pushed the adv_velox_1 branch from d1cc700 to faff178 Compare October 23, 2025 21:52

tanjialiang force-pushed the adv_velox_1 branch from faff178 to 3c574d1 Compare October 23, 2025 22:54

tanjialiang force-pushed the adv_velox_1 branch 2 times, most recently from f2eb9a3 to a40c13b Compare October 24, 2025 04:57

tanjialiang requested a review from aditi-pandit October 24, 2025 17:33

amitkdutta previously approved these changes Oct 24, 2025

View reviewed changes

aditi-pandit previously approved these changes Oct 24, 2025

View reviewed changes

aditi-pandit changed the title ~~misc: Advance Velox~~ chore: Advance Velox Oct 24, 2025

tanjialiang requested a review from zacw7 October 24, 2025 18:21

zacw7 previously approved these changes Oct 24, 2025

View reviewed changes

tdcmeehan changed the title ~~chore: Advance Velox~~ chore(ci): Advance Velox Oct 24, 2025

misc: Advance Velox

66db087

tanjialiang dismissed stale reviews from zacw7, aditi-pandit, and amitkdutta via 66db087 October 24, 2025 23:38

tanjialiang force-pushed the adv_velox_1 branch from a40c13b to 66db087 Compare October 24, 2025 23:38

tanjialiang requested review from aditi-pandit and zacw7 October 25, 2025 06:29

aditi-pandit approved these changes Oct 25, 2025

View reviewed changes

aditi-pandit merged commit 2070d2d into prestodb:master Oct 25, 2025
79 checks passed

chore(ci): Advance Velox #26385

chore(ci): Advance Velox #26385

Conversation

tanjialiang commented Oct 21, 2025

Uh oh!

sourcery-ai bot commented Oct 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer's Guide

File-Level Changes

Interacting with Sourcery

Customizing Your Experience

Getting Help

Uh oh!

sourcery-ai bot left a comment

Choose a reason for hiding this comment

Uh oh!

aditi-pandit left a comment

Choose a reason for hiding this comment

Uh oh!

unidevel commented Oct 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

czentgr commented Oct 22, 2025

Uh oh!

czentgr commented Oct 22, 2025

Uh oh!

simoneves commented Oct 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mbasmanova commented Oct 22, 2025

Uh oh!

simoneves commented Oct 22, 2025

Uh oh!

aditi-pandit commented Oct 23, 2025

Uh oh!

amitkdutta commented Oct 23, 2025

Uh oh!

tanjialiang commented Oct 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

czentgr commented Oct 23, 2025

Uh oh!

amitkdutta left a comment

Choose a reason for hiding this comment

Uh oh!

aditi-pandit left a comment

Choose a reason for hiding this comment

Uh oh!

aditi-pandit Oct 24, 2025

Choose a reason for hiding this comment

Uh oh!

tanjialiang Oct 24, 2025

Choose a reason for hiding this comment

Uh oh!

aditi-pandit commented Oct 24, 2025

Uh oh!

aditi-pandit commented Oct 24, 2025

Uh oh!

aditi-pandit left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

sourcery-ai bot commented Oct 21, 2025 •

edited

Loading

unidevel commented Oct 22, 2025 •

edited

Loading

simoneves commented Oct 22, 2025 •

edited

Loading

tanjialiang commented Oct 23, 2025 •

edited

Loading