Skip to content

Add tilde expansion to paths on Linux platforms #3721

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
EmilyBZhang wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add tilde expansion to paths on Linux platforms #3721

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@ All notable changes to the "prettier-vscode" extension will be documented in thi

## [Unreleased]

- Add tilde expansion to paths on Linux platforms

## [12.4.0]

- **Security**: Fixed config resolution in untrusted workspaces to prevent JavaScript config files (`.prettierrc.js`, `prettier.config.js`, etc.) from being executed. Previously, even when workspace trust was enforced for module resolution, Prettier's config resolution could still `require()`/`import()` JS config files, allowing arbitrary code execution. Reported by Hector Ruiz Ruiz.
Expand Down
4 changes: 2 additions & 2 deletions src/utils/workspace.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,9 @@ export function getWorkspaceRelativePath(
filePath: string,
pathToResolve: string,
) {
// In case the user wants to use ~/.prettierrc on Mac
// In case the user wants to use ~/.prettierrc on Mac or Linux
if (
process.platform === "darwin" &&
(process.platform === "darwin" || process.platform === "linux") &&
pathToResolve.indexOf("~") === 0 &&
os.homedir()
) {
Expand Down