feat: 사용자의 브라우저 설정에 따라 테마 자동 설정 #177
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
AAminha
reviewed
Apr 5, 2025
wldnjs990
reviewed
Apr 5, 2025
Comment on lines
10
to
16
| const getAutoTheme = (): 'light' | 'dark' => { | ||
| if (window.matchMedia && window.matchMedia('(prefers-color-scheme: dark)').matches) { | ||
| return 'dark'; | ||
| } | ||
| return 'light'; | ||
| }; | ||
|
|
There was a problem hiding this comment.
이런 기능이 있었군요 ㄷㄷㄷㄷ 또 배워갑니다!!🦆🦆🦆
wldnjs990
approved these changes
Jun 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ 요약
🪄 변경사항
기존에는 시간대에 따라 테마가 자동으로 설정되도록 구현했지만, 어제 피드백을 받고 사용자의 브라우저 설정을 반영하는 방식이 더 적절하다고 판단해 해당 방식으로 수정했습니다.
prefers-color-scheme설정을 반영하여 테마를 적용하도록 변경🖼️ 결과 화면 (선택)
💬 리뷰어에게 전할 말 (선택)