Skip to content

Commit 55c9dc6

Browse files
committed
chore : review 반영
1 parent e783770 commit 55c9dc6

File tree

6 files changed

+6
-17
lines changed

6 files changed

+6
-17
lines changed

β€Žsrc/main/java/com/dadok/gaerval/domain/bookshelf/exception/AlreadyExistsBookshelfLikeException.java

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@
22

33
import static com.dadok.gaerval.global.error.ErrorCode.*;
44

5-
import com.dadok.gaerval.global.error.ErrorCode;
65
import com.dadok.gaerval.global.error.exception.BusinessException;
76

87
public class AlreadyExistsBookshelfLikeException extends BusinessException {
@@ -11,13 +10,4 @@ public AlreadyExistsBookshelfLikeException(Long bookshelfId) {
1110
super(ALREADY_EXISTS_BOOKSHELF_LIKE, String.format(ALREADY_EXISTS_BOOKSHELF_LIKE.getMessage(), bookshelfId));
1211
}
1312

14-
@Override
15-
public String getMessage() {
16-
return super.getMessage();
17-
}
18-
19-
@Override
20-
public ErrorCode getErrorCode() {
21-
return ALREADY_EXISTS_BOOKSHELF_LIKE;
22-
}
2313
}

β€Žsrc/main/java/com/dadok/gaerval/domain/bookshelf/repository/BookshelfLikeSupport.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,5 +2,5 @@
22

33
public interface BookshelfLikeSupport {
44

5-
boolean existsByBookshelfIdAndUserId(Long bookshelfId, Long userId);
5+
boolean existsLike(Long bookshelfId, Long userId);
66
}

β€Žsrc/main/java/com/dadok/gaerval/domain/bookshelf/repository/BookshelfLikeSupportImpl.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ public class BookshelfLikeSupportImpl implements BookshelfLikeSupport {
1212
private final JPAQueryFactory query;
1313

1414
@Override
15-
public boolean existsByBookshelfIdAndUserId(Long bookshelfId, Long userId) {
15+
public boolean existsLike(Long bookshelfId, Long userId) {
1616
Integer fetchOne = query.selectOne().from(bookshelfLike)
1717
.where(bookshelfLike.bookshelf.id.eq(bookshelfId), bookshelfLike.user.id.eq(userId))
1818
.fetchFirst();

β€Žsrc/main/java/com/dadok/gaerval/domain/bookshelf/service/DefaultBookshelfLikeService.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ public class DefaultBookshelfLikeService implements BookshelfLikeService {
2828
public void createBookshelfLike(Long userId, Long bookshelfId) {
2929
User user = userService.getById(userId);
3030
Bookshelf bookshelf = bookshelfService.getById(bookshelfId);
31-
if (bookshelfLikeRepository.existsByBookshelfIdAndUserId(bookshelfId, userId)) {
31+
if (bookshelfLikeRepository.existsLike(bookshelfId, userId)) {
3232
throw new AlreadyExistsBookshelfLikeException(bookshelf.getId());
3333
}
3434
bookshelfLikeRepository.save(BookshelfLike.create(user, bookshelf));

β€Žsrc/test/java/com/dadok/gaerval/domain/bookshelf/repository/BookshelfLikeRepositoryTest.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,6 @@ void findByUserIdAndBookshelfId() {
2525
@Test
2626
@DisplayName("μ±…μž₯κ³Ό μ‚¬μš©μžλ₯Ό μž…λ ₯λ°›μ•„ 쑴재 μ—¬λΆ€ 확인")
2727
void existsByBookshelfIdAndUserId() {
28-
bookshelfLikeRepository.existsByBookshelfIdAndUserId(2L, 4L);
28+
bookshelfLikeRepository.existsLike(2L, 4L);
2929
}
30-
3130
}

β€Žsrc/test/java/com/dadok/gaerval/domain/bookshelf/service/DefaultBookshelfLikeServiceTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ void createBookshelfLike_success() {
4949
.willReturn(user);
5050
given(bookshelfService.getById(2L))
5151
.willReturn(bookshelf);
52-
given(bookshelfLikeRepository.existsByBookshelfIdAndUserId(2L, 1L))
52+
given(bookshelfLikeRepository.existsLike(2L, 1L))
5353
.willReturn(Boolean.FALSE);
5454

5555
// When
@@ -69,7 +69,7 @@ void createBookshelfLike_alreadyExist_fail() {
6969
.willReturn(user);
7070
given(bookshelfService.getById(2L))
7171
.willReturn(bookshelf);
72-
given(bookshelfLikeRepository.existsByBookshelfIdAndUserId(2L, 1L))
72+
given(bookshelfLikeRepository.existsLike(2L, 1L))
7373
.willReturn(Boolean.TRUE);
7474

7575
// When // Then

0 commit comments

Comments
Β (0)