Skip to content

Conversation

francinelucca
Copy link
Member

@francinelucca francinelucca commented Oct 16, 2025

Removes NavList.Group, NavList.GroupHeading styled wrappers, refactors NavList styled wrappers to use styled() convention instead of Box

Changelog

New

  • Add missing isSlot checks to NavList

Changed

  • Refactor NavList styled wrappers to use styled() instead of Box and to correctly forward the "as" prop

Removed

  • styled wrappers for NavList.Group, NavList.GroupHeading
  • tests that are no longer valid

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

@francinelucca francinelucca requested review from a team as code owners October 16, 2025 02:30
Copy link

changeset-bot bot commented Oct 16, 2025

🦋 Changeset detected

Latest commit: 2da51bf

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@primer/react Patch
@primer/styled-react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

This reverts commit 24e8f49.
@github-actions github-actions bot added the staff Author is a staff member label Oct 16, 2025
Copy link
Contributor

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Oct 16, 2025
Removed unneeded exports from navlist and added missing isSlot checks.
@primer-integration
Copy link

👋 Hi from github/github-ui! Your integration PR is ready: https://github.com/github/github-ui/pull/4796

@github-actions github-actions bot added integration-tests: failing Changes in this PR cause breaking changes in gh/gh and removed integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Oct 16, 2025
@primer-integration
Copy link

🟢 ci completed with status success.

@github-actions github-actions bot added integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh and removed integration-tests: failing Changes in this PR cause breaking changes in gh/gh labels Oct 16, 2025
Copy link
Member

@siddharthkp siddharthkp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved!

Clean up suggestion at a later stage: Because there is only instance of NavList with sx now, we could also update that instance and remove NavList from styled-react

@francinelucca francinelucca added this pull request to the merge queue Oct 16, 2025
Merged via the queue into main with commit 4308179 Oct 16, 2025
43 checks passed
@francinelucca francinelucca deleted the chore/navlist-remove-unneeded-exports branch October 16, 2025 14:19
@primer primer bot mentioned this pull request Oct 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh staff Author is a staff member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants