-
Notifications
You must be signed in to change notification settings - Fork 638
Chore(navlist): remove unneeded exports #7019
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: 2da51bf The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This reverts commit 24e8f49.
👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks! |
Removed unneeded exports from navlist and added missing isSlot checks.
👋 Hi from github/github-ui! Your integration PR is ready: https://github.com/github/github-ui/pull/4796 |
🟢 ci completed with status |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved!
Clean up suggestion at a later stage: Because there is only instance of NavList with sx now, we could also update that instance and remove NavList from styled-react
Removes NavList.Group, NavList.GroupHeading styled wrappers, refactors NavList styled wrappers to use styled() convention instead of Box
Changelog
New
Changed
Removed
Rollout strategy
Testing & Reviewing
Merge checklist