-
Notifications
You must be signed in to change notification settings - Fork 641
Update release workflows for NPM OIDC trusted publishing #7100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR consolidates GitHub release workflows and standardizes repository field formatting across package.json files. The changes streamline the release process by merging three separate workflow files into a single unified workflow.
- Standardizes the
repositoryfield format in package.json files to use the expanded object notation withtypeandurlproperties - Consolidates
release_candidate.ymlandrelease_canary.ymlinto the mainrelease.ymlworkflow file - Updates the release workflow trigger to use
pushon any branch and addsworkflow_dispatchfor manual triggering
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/react/package.json | Expanded repository field from shorthand string to object notation |
| packages/styled-react/package.json | Added repository field with full git URL |
| packages/mcp/package.json | Added repository field with full git URL |
| .github/workflows/release.yml | Merged candidate and canary release jobs into main workflow, removed branch filtering, added workflow_dispatch trigger |
| .github/workflows/release_candidate.yml | Removed (consolidated into release.yml) |
| .github/workflows/release_canary.yml | Removed (consolidated into release.yml) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Only one allowed workflow is a bummer, but it will have to do!
Part of https://github.com/github/primer/issues/6015
I also have a companion PR that will need to ship after this change to fix the integration workflows https://github.com/github/github-ui/pull/5972
This updates our workflows to allow for the NPM trusted publishing. With this we will no longer need to use tokens to publish the packages. https://docs.npmjs.com/trusted-publishers
One caveat though is that the configuration only allows for one workflow to publish. Because of this I needed to combine release.yml, release_candidate.yml, release_canary.yml into 1 file.
Testing & Reviewing
I tested the canary release obviously here, I'm not sure we can test the main and candidate scenario without merging and fixing any issues that might exist. So in review, take a closer look at the
release-main:andrelease-candidate:jobs.Merge checklist