Change label group to ul/li so that they are individually reachable#7485
Closed
llastflowers wants to merge 4 commits intomainfrom
Closed
Change label group to ul/li so that they are individually reachable#7485llastflowers wants to merge 4 commits intomainfrom
llastflowers wants to merge 4 commits intomainfrom
Conversation
…nd can be announced separately by SR
🦋 Changeset detectedLatest commit: fa4e5da The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Change label group to ul/li for individual accessibility.
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request improves accessibility by changing the label group structure from plain div elements to semantic ul/li elements, making labels individually reachable and separately announced by screen readers.
Changes:
- Converted the
GroupOfLabelsstory to useStackwithas="ul"prop - Wrapped each
IssueLabelinlielements for proper list semantics - Added a new CSS module (
IssueLabel.features.stories.module.css) to reset list styling
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| packages/react/src/experimental/IssueLabel/IssueLabel.features.stories.tsx | Updated GroupOfLabels story to use semantic ul/li structure with Stack component |
| packages/react/src/experimental/IssueLabel/IssueLabel.features.stories.module.css | New CSS module to reset list styles and maintain visual appearance |
packages/react/src/experimental/IssueLabel/IssueLabel.features.stories.module.css
Show resolved
Hide resolved
packages/react/src/experimental/IssueLabel/IssueLabel.features.stories.module.css
Show resolved
Hide resolved
github-actions
bot
requested a deployment
to
storybook-preview-7485
llastflowers
added
the
integration-tests: skipped manually
Contributor
Author
|
integration tests skipped; Storybook-only changes |
Contributor
Author
|
issue closed as not planned |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses https://github.com/github/accessibility-audits/issues/15026
Changelog
New
New CSS module to override list styling and make the story look exactly the same as before
Changed
Change label group to ul/li so that they are individually reachable and can be announced separately by SR
Rollout strategy
Testing & Reviewing
Merge checklist