Skip to content

Commit d8fff00

Browse files
committed
set pageview count of forked session to 0
1 parent 547d636 commit d8fff00

File tree

2 files changed

+5
-2
lines changed

2 files changed

+5
-2
lines changed

pkg/handlers/events_pageviews.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -123,6 +123,7 @@ func eventsPageviewsHandler(
123123
return fmt.Errorf("failed to generate session uuid: %w", err)
124124
}
125125

126+
session.PageviewCount = 0
126127
session.PageUri = pageView.PageUri
127128
sessionStorage.InsertSession(deviceId, session)
128129

tests/bun/events/session.test.ts

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -323,12 +323,14 @@ test('session duplicate pageview on second pageview followed by fork on third pa
323323
const session = await getLatestSession()
324324

325325
// There is two different sessions now.
326-
if (i === 0) firstSession = session
326+
if (i === 0) { firstSession = session;
327+
expect(session.version).toEqual(3)
328+
}
327329
else {
328330
expect(session).not.toEqual(firstSession)
331+
expect(session.version).toEqual(1)
329332
}
330333

331-
expect(session.version).toEqual(3)
332334
}
333335
}, { timeout: 30_000 })
334336

0 commit comments

Comments
 (0)