♻️ complete code unification with set_variables pattern and repository migration

- Unified all remaining API routes to use consistent set_variables pattern
- Migrated get_users_list to users repository following factory pattern
- Added comprehensive test suite for GetUsersList with snapshots
- Updated CONTRIBUTING.md with snapshot testing convention
- Request processing stays in middleware, page_title in render functions
- Clean architecture: data loading consolidated in loadPageVariables functions

Author: douglasduteil

CONTRIBUTING.md

@@ -173,6 +173,7 @@ Write comprehensive tests following these guidelines:
 2. **Database Setup**: Always include `beforeAll(migrate)` and `beforeEach(empty_database)`
 3. **Seed Data**: Use unicorn seed functions (e.g., `create_adora_pony_user`, `create_unicorn_organization`)
 4. **Snapshots Over Multiple Expects**: Prefer `toMatchInlineSnapshot()` for complex object assertions
+5. **Auto-generated Snapshots**: When using `toMatchInlineSnapshot()`, let Bun test write the string value automatically by running the test first with an empty string or no parameter
 
 ### Example
 
@@ -202,13 +203,15 @@ test("returns user with specified columns", async () => {
   });
   const result = await get_user_by_id(user_id);
 
+  // Let Bun auto-generate the snapshot by running test first with empty string
   expect(result).toMatchInlineSnapshot(`
-{
-  "email": "adora.pony@unicorn.xyz",
-  "given_name": "Adora", 
-  "id": ${user_id},
-}
-`);
+    {
+      "email": "adora.pony@unicorn.xyz",
+      "family_name": "Pony",
+      "given_name": "Adora",
+      "id": 1,
+    }
+  `);
 });
 ```
 

sources/moderations/api/src/:id/duplicate_warning/context.ts

@@ -0,0 +1,59 @@
+//
+
+import { Entity_Schema } from "@~/app.core/schema";
+import type { App_Context } from "@~/app.middleware/context";
+import type { IdentiteProconnect_PgDatabase } from "@~/identite-proconnect.database";
+import { Duplicate_Warning } from "./Duplicate_Warning";
+import type { Env } from "hono";
+import { useRequestContext } from "hono/jsx-renderer";
+import { z } from "zod";
+
+//
+
+export async function loadDuplicateWarningPageVariables(
+  pg: IdentiteProconnect_PgDatabase,
+  { moderation_id, organization_id, user_id }: { 
+    moderation_id: number; 
+    organization_id: number; 
+    user_id: number; 
+  },
+) {
+  const value = await Duplicate_Warning.queryContextValues(pg, {
+    moderation_id,
+    organization_id,
+    user_id,
+  });
+
+  return value;
+}
+
+//
+
+export interface ContextVariablesType extends Env {
+  Variables: Awaited<ReturnType<typeof loadDuplicateWarningPageVariables>>;
+}
+export type ContextType = App_Context & ContextVariablesType;
+
+//
+
+export const QuerySchema = z.object({
+  organization_id: z.string().pipe(z.coerce.number().int().nonnegative()),
+  user_id: z.string().pipe(z.coerce.number().int().nonnegative()),
+});
+
+export const ParamSchema = Entity_Schema;
+
+//
+
+type PageInputType = {
+  out: {
+    param: z.input<typeof ParamSchema>;
+    query: z.input<typeof QuerySchema>;
+  };
+};
+
+export const usePageRequestContext = useRequestContext<
+  ContextType,
+  any,
+  PageInputType
+>;

sources/moderations/api/src/:id/duplicate_warning/index.tsx

@@ -1,39 +1,36 @@
 //
 
 import { zValidator } from "@hono/zod-validator";
-import { Entity_Schema } from "@~/app.core/schema";
-import type { IdentiteProconnect_Pg_Context } from "@~/app.middleware/set_identite_pg";
+import { set_variables } from "@~/app.middleware/context/set_variables";
 import { Hono } from "hono";
 import { jsxRenderer } from "hono/jsx-renderer";
-import { z } from "zod";
 import { Duplicate_Warning } from "./Duplicate_Warning";
+import { loadDuplicateWarningPageVariables, ParamSchema, QuerySchema, type ContextType } from "./context";
 
 //
 
-export default new Hono<IdentiteProconnect_Pg_Context>().get(
-  "/",
-  jsxRenderer(),
-  zValidator("param", Entity_Schema),
-  zValidator(
-    "query",
-    z.object({
-      organization_id: z.string().pipe(z.coerce.number().int().nonnegative()),
-      user_id: z.string().pipe(z.coerce.number().int().nonnegative()),
-    }),
-  ),
-  async function GET({ render, req, var: { identite_pg } }) {
-    const { id } = req.valid("param");
-    const { organization_id, user_id } = req.valid("query");
-    const value = await Duplicate_Warning.queryContextValues(identite_pg, {
-      moderation_id: id,
-      organization_id,
-      user_id,
-    });
-
-    return render(
-      <Duplicate_Warning.Context.Provider value={value}>
-        <Duplicate_Warning />
-      </Duplicate_Warning.Context.Provider>,
-    );
-  },
-);
+export default new Hono<ContextType>()
+  .get(
+    "/",
+    jsxRenderer(),
+    zValidator("param", ParamSchema),
+    zValidator("query", QuerySchema),
+    async function set_variables_middleware({ req, set, var: { identite_pg } }, next) {
+      const { id: moderation_id } = req.valid("param");
+      const { organization_id, user_id } = req.valid("query");
+      const variables = await loadDuplicateWarningPageVariables(identite_pg, {
+        moderation_id,
+        organization_id,
+        user_id,
+      });
+      set_variables(set, variables);
+      return next();
+    },
+    async function GET({ render, var: variables }) {
+      return render(
+        <Duplicate_Warning.Context.Provider value={variables}>
+          <Duplicate_Warning />
+        </Duplicate_Warning.Context.Provider>,
+      );
+    },
+  );

sources/moderations/api/src/context.ts

@@ -1,10 +1,13 @@
 //
 
 import { Pagination_Schema, type Pagination } from "@~/app.core/schema";
+import type { App_Context } from "@~/app.middleware/context";
 import { z_coerce_boolean } from "@~/app.core/schema/z_coerce_boolean";
 import { z_empty_string_to_undefined } from "@~/app.core/schema/z_empty_string_to_undefined";
 import type { GetModerationsListHandler } from "@~/moderations.repository";
 import { createContext } from "hono/jsx";
+import type { Env } from "hono";
+import { useRequestContext } from "hono/jsx-renderer";
 import { z } from "zod";
 
 //
@@ -31,6 +34,30 @@ export type GetModerationsListDTO = Awaited<
   ReturnType<GetModerationsListHandler>
 >;
 
+export async function loadModerationsListPageVariables(
+  { pagination, search }: { pagination: Pagination; search: Search },
+) {
+  return {
+    pagination,
+    search,
+  };
+}
+
+//
+
+export interface ContextVariablesType extends Env {
+  Variables: Awaited<ReturnType<typeof loadModerationsListPageVariables>>;
+}
+export type ContextType = App_Context & ContextVariablesType;
+
+//
+
+export const usePageRequestContext = useRequestContext<
+  ContextType,
+  any,
+  any
+>();
+
 export default createContext({
   query_moderations_list: {} as Promise<GetModerationsListDTO>,
   pagination: {} as Pagination,

sources/moderations/api/src/index.tsx

@@ -3,43 +3,52 @@
 import { Pagination_Schema } from "@~/app.core/schema";
 import { Main_Layout } from "@~/app.layout/index";
 import { authorized } from "@~/app.middleware/authorized";
-import type { App_Context } from "@~/app.middleware/context";
+import { set_variables } from "@~/app.middleware/context/set_variables";
 import { Hono } from "hono";
 import { jsxRenderer } from "hono/jsx-renderer";
 import { P, match } from "ts-pattern";
 import moderation_router from "./:id/index";
-import { Search_Schema } from "./context";
+import { loadModerationsListPageVariables, Search_Schema, type ContextType } from "./context";
 import { Moderations_Page } from "./page";
 
 //
-export default new Hono<App_Context>()
+export default new Hono<ContextType>()
   .use(authorized())
 
   .route("/:id", moderation_router)
-  .get("/", jsxRenderer(Main_Layout), function GET({ render, req, set }) {
-    const query = req.query();
+  .get(
+    "/",
+    jsxRenderer(Main_Layout),
+    async function set_variables_middleware({ req, set }, next) {
+      const query = req.query();
 
-    const search = match(Search_Schema.parse(query, { path: ["query"] }))
-      .with(
-        { search_email: P.not("") },
-        { search_siret: P.not("") },
-        (search) => ({
-          ...search,
-          hide_join_organization: false,
-          hide_non_verified_domain: false,
-          processed_requests: true,
-        }),
-      )
-      .otherwise((search) => search);
+      const search = match(Search_Schema.parse(query, { path: ["query"] }))
+        .with(
+          { search_email: P.not("") },
+          { search_siret: P.not("") },
+          (search) => ({
+            ...search,
+            hide_join_organization: false,
+            hide_non_verified_domain: false,
+            processed_requests: true,
+          }),
+        )
+        .otherwise((search) => search);
 
-    const pagination = match(
-      Pagination_Schema.safeParse(query, { path: ["query"] }),
-    )
-      .with({ success: true }, ({ data }) => data)
-      .otherwise(() => Pagination_Schema.parse({}));
+      const pagination = match(
+        Pagination_Schema.safeParse(query, { path: ["query"] }),
+      )
+        .with({ success: true }, ({ data }) => data)
+        .otherwise(() => Pagination_Schema.parse({}));
 
-    set("page_title", "Liste des moderations");
-    return render(<Moderations_Page pagination={pagination} search={search} />);
-  });
+      const variables = await loadModerationsListPageVariables({ pagination, search });
+      set_variables(set, variables);
+      return next();
+    },
+    function GET({ render, set, var: { pagination, search } }) {
+      set("page_title", "Liste des moderations");
+      return render(<Moderations_Page pagination={pagination} search={search} />);
+    },
+  );
 
 //

sources/organizations/api/src/:id/members/context.ts

@@ -1,27 +1,51 @@
 //
 
-import type { Pagination } from "@~/app.core/schema";
+import { type Pagination } from "@~/app.core/schema";
 import type { App_Context } from "@~/app.middleware/context";
 import { urls } from "@~/app.urls";
-import { type GetUsersByOrganizationIdDto } from "@~/users.repository";
+import type { IdentiteProconnect_PgDatabase } from "@~/identite-proconnect.database";
+import {
+  GetUsersByOrganizationId,
+  type GetUsersByOrganizationIdDto,
+} from "@~/users.repository";
 import type { Env, InferRequestType } from "hono";
 import { createContext } from "hono/jsx";
 import { useRequestContext } from "hono/jsx-renderer";
 
 //
 
+export async function loadMembersPageVariables(
+  pg: IdentiteProconnect_PgDatabase,
+  {
+    organization_id,
+    pagination,
+  }: {
+    organization_id: number;
+    pagination: Pagination;
+  },
+) {
+  const query_members_collection = GetUsersByOrganizationId(pg)({
+    organization_id,
+    pagination: { ...pagination, page: pagination.page - 1 },
+  });
+
+  return {
+    organization_id,
+    pagination,
+    query_members_collection,
+  };
+}
+
+//
+
 export const Member_Context = createContext({
   user: {} as GetUsersByOrganizationIdDto["users"][number],
 });
 
 //
 
 export interface ContextVariablesType extends Env {
-  Variables: {
-    organization_id: number;
-    pagination: Pagination;
-    query_members_collection: Promise<GetUsersByOrganizationIdDto>;
-  };
+  Variables: Awaited<ReturnType<typeof loadMembersPageVariables>>;
 }
 export type ContextType = App_Context & ContextVariablesType;
 

sources/organizations/api/src/:id/members/index.tsx

@@ -6,14 +6,14 @@ import {
   Entity_Schema,
   Pagination_Schema,
 } from "@~/app.core/schema";
-import { GetUsersByOrganizationId } from "@~/users.repository";
+import { set_variables } from "@~/app.middleware/context/set_variables";
 import { Hono } from "hono";
 import { jsxRenderer } from "hono/jsx-renderer";
 import { match } from "ts-pattern";
 import { z } from "zod";
 import organization_member_router from "./:user_id";
 import { Table } from "./Table";
-import type { ContextType } from "./context";
+import { loadMembersPageVariables, type ContextType } from "./context";
 
 //
 
@@ -32,34 +32,17 @@ export default new Hono<ContextType>()
         page_ref: z.string(),
       }),
     ),
-
-    function set_organization_id({ req, set }, next) {
+    async function set_variables_middleware({ req, set, var: { identite_pg } }, next) {
       const { id: organization_id } = req.valid("param");
-      set("organization_id", organization_id);
-      return next();
-    },
-    function set_query_members_collection(
-      { req, set, var: { identite_pg, organization_id } },
-      next,
-    ) {
-      const query = req.query();
       const pagination = match(
-        Pagination_Schema.safeParse(query, { path: ["query"] }),
+        Pagination_Schema.safeParse(req.query(), { path: ["query"] }),
       )
         .with({ success: true }, ({ data }) => data)
         .otherwise(() => Pagination_Schema.parse({}));
-
-      set("pagination", pagination);
-      set(
-        "query_members_collection",
-        GetUsersByOrganizationId(identite_pg)({
-          organization_id,
-          pagination: { ...pagination, page: pagination.page - 1 },
-        }),
-      );
+      const variables = await loadMembersPageVariables(identite_pg, { organization_id, pagination });
+      set_variables(set, variables);
       return next();
     },
-
     async function GET({ render }) {
       return render(<Table />);
     },