✅ add test for feature armee suggestion

Author: BenoitSerrano

cypress/e2e/signup_with_suggestion/env.conf

@@ -0,0 +1,9 @@
+INSERT INTO
+  organizations (id, siret, created_at, updated_at)
+VALUES
+  (
+    1,
+    '11009001600053',
+    CURRENT_TIMESTAMP,
+    CURRENT_TIMESTAMP
+  );

cypress/e2e/signup_with_suggestion/fixtures.sql

@@ -0,0 +1,34 @@
+//
+
+describe("sign-up with suggestion", () => {
+  it("should seed the database once", function () {
+    cy.seed();
+  });
+
+  it("should sign-up with magic link and be suggested the Ministere des armees organization", function () {
+    // Visit the signup page
+    cy.visit("/users/start-sign-in");
+
+    cy.get('[name="login"]').type("user@intradef.gouv.fr");
+    cy.get('[type="submit"]').click();
+
+    cy.get('[name="password"]').type(
+      "This super secret password is hidden well!",
+    );
+    cy.get('[action="/users/sign-up"]  [type="submit"]').click();
+
+    // Check that the website is waiting for the user to verify their email
+    cy.get("#verify-email > div > p").contains("user@intradef.gouv.fr");
+
+    cy.verifyEmail();
+
+    // Fill the user's personal information
+    cy.get('[name="given_name"]').type("Loïs");
+    cy.get('[name="family_name"]').type("Lane");
+    cy.get('[type="submit"]').click();
+
+    // Check that the ministere des armees is preselected
+    cy.url().should("include", "users/organization-suggestions");
+    cy.get("#submit-join-organization-1").contains("Ministere des armees");
+  });
+});

cypress/e2e/signup_with_suggestion/index.cy.ts

@@ -50,10 +50,10 @@ import {
   findRejectedModeration,
 } from "../../repositories/moderation";
 import {
+  findBySiret,
   findByUserId,
   findByVerifiedEmailDomain,
   getById,
-  getBySiret,
 } from "../../repositories/organization/getters";
 import {
   linkUserToOrganization,
@@ -113,7 +113,7 @@ export const getOrganizationSuggestions = async ({
   }
 
   if (isArmeeDomain(domain)) {
-    const armeeOrganization = await getBySiret("11009001600053");
+    const armeeOrganization = await findBySiret("11009001600053");
     if (armeeOrganization) {
       return [armeeOrganization];
     }

src/managers/organization/join.ts

@@ -17,12 +17,12 @@ export const findByUserId = findByUserIdFactory({
   pg: getDatabaseConnection(),
 });
 
-export const getBySiret = async (siret: string) => {
+export const findBySiret = async (siret: string) => {
   const connection = getDatabaseConnection();
 
   const { rows }: QueryResult<Organization> = await connection.query(
     `
-SELECT id, siret
+SELECT *
 FROM organizations
 WHERE siret = $1
 `,