refacto: improvement after review

Author: rebeccadumazert

cypress/e2e/signin_with_totp/index.cy.ts

@@ -1,5 +1,5 @@
 describe("sign-in with TOTP on untrusted browser", () => {
-  it.only("should seed the database once", function () {
+  it("should seed the database once", function () {
     cy.seed();
   });
 
@@ -36,7 +36,7 @@ describe("sign-in with TOTP on untrusted browser", () => {
     cy.contains('"amr": [\n    "pwd",\n    "totp",\n    "mfa"\n  ],');
   });
 
-  it.only("should sign-in with TOTP when forced by SP, password only otherwise", function () {
+  it("should sign-in with TOTP when forced by SP, password only otherwise", function () {
     cy.visit("http://localhost:4000");
     cy.get("button.proconnect-button").click();
 

src/controllers/user/two-factors-authentication-configuration.ts

@@ -53,9 +53,7 @@ export const getIsTotpAppInstalledController = async (
   next: NextFunction,
 ) => {
   try {
-    const schema = z.object({
-      "2fa_force": optionalBooleanSchema(),
-    });
+    const schema = z.object({ "2fa_force": optionalBooleanSchema() });
 
     const { "2fa_force": temporaryForce2fa } = await schema.parseAsync(
       req.query,

src/managers/totp.ts

@@ -64,11 +64,7 @@ export const confirmTotpRegistration = async (
     totp_key_verified_at: new Date(),
   });
 
-  if (temporaryForce2fa) {
-    return await enableForce2fa(user_id);
-  } else {
-    return await disableForce2fa(user_id);
-  }
+  return temporaryForce2fa ? enableForce2fa(user_id) : disableForce2fa(user_id);
 };
 
 export const deleteTotpConfiguration = async (user_id: number) => {

src/views/user/double-authentication-choice.ejs

@@ -50,7 +50,6 @@
       <div class="fr-checkbox-group fr-pl-1w fr-pb-2w">
         <input name="2fa_force" id="mfa-proconnect-config" type="checkbox" aria-describedby="mfa-proconnect-config-messages">
         <label class="fr-label" for="mfa-proconnect-config">Je configure la 2FA sur l'ensemble des sites que j'utilise avec ProConnect<span class="fr-hint-text">Par défaut, la 2FA s'applique uniquement aux sites qui l'exigent</span></label>
-        <div class="fr-messages-group" id="mfa-proconnect-config-messages" aria-live="polite">
         </div>
       </div>
     </fieldset>