chore(error): little homogenization

Author: douglasduteil

src/config/errors.ts

@@ -1,32 +1,47 @@
 export class InvalidEmailError extends Error {
-  constructor(public didYouMean: string) {
-    super();
-    this.didYouMean = didYouMean;
+  constructor(
+    public didYouMean: string,
+    options?: ErrorOptions,
+  ) {
+    super(`Did you mean "${didYouMean}" ?`, options);
+    this.name = "InvalidEmailError";
   }
 }
 
 export class ForbiddenError extends Error {}
 
 export class UnableToAutoJoinOrganizationError extends Error {
-  constructor(public moderationId: number) {
-    super();
-    this.moderationId = moderationId;
+  constructor(
+    public moderationId: number,
+    options?: ErrorOptions,
+  ) {
+    super(`Linked to moderation ${moderationId}`, options);
+    this.name = "UnableToAutoJoinOrganizationError";
   }
 }
 
 export class UserInOrganizationAlreadyError extends Error {}
 
 export class UserAlreadyAskedToJoinOrganizationError extends Error {
-  constructor(public moderationId: number) {
-    super();
-    this.moderationId = moderationId;
+  constructor(
+    public moderationId: number,
+    options: ErrorOptions,
+  ) {
+    super(
+      `Moderation ${moderationId} already asked to join organization`,
+      options,
+    );
+    this.name = "UserAlreadyAskedToJoinOrganizationError";
   }
 }
 
 export class UserMustConfirmToJoinOrganizationError extends Error {
-  constructor(public organizationId: number) {
-    super();
-    this.organizationId = organizationId;
+  constructor(
+    public organizationId: number,
+    options?: ErrorOptions,
+  ) {
+    super(`Organization ${organizationId} confirmation is required`, options);
+    this.name = "UserMustConfirmToJoinOrganizationError";
   }
 }
 
@@ -42,7 +57,7 @@ export class DomainRestrictedError extends Error {
     public organizationId: number,
     options?: ErrorOptions,
   ) {
-    super("", options);
+    super(`Organization ${organizationId} is domain restricted`, options);
     this.name = "DomainRestrictedError";
   }
 }
@@ -109,10 +124,10 @@ export class OidcError extends Error {
   constructor(
     public error: string,
     public error_description?: string,
+    options?: ErrorOptions,
   ) {
-    super();
-    this.error = error;
-    this.error_description = error_description;
+    super(`${error}: ${error_description}`, options);
+    this.name = "OidcError";
   }
 }
 

src/controllers/interaction.ts

@@ -1,4 +1,5 @@
 import type { NextFunction, Request, Response } from "express";
+import { AssertionError } from "node:assert";
 import Provider, { errors } from "oidc-provider";
 import { z } from "zod";
 import { FEATURE_ALWAYS_RETURN_EIDAS1_FOR_ACR } from "../config/env";
@@ -131,6 +132,13 @@ export const interactionEndControllerFactory =
           new OidcError(
             "access_denied",
             "none of the requested ACRs could be obtained",
+            {
+              cause: new AssertionError({
+                expected: prompt,
+                actual: currentAcr,
+                operator: "isAcrSatisfied",
+              }),
+            },
           ),
         );
       }

src/controllers/user/franceconnect.ts

@@ -40,7 +40,9 @@ export async function getFranceConnectLoginCallbackMiddleware(
 
     if (errorQuery.success) {
       const { error, error_description } = errorQuery.data;
-      throw new OidcError(error, error_description);
+      throw new OidcError(error, error_description, {
+        cause: errorQuery.error,
+      });
     }
     const { code } = await z.object({ code: z.string() }).parseAsync(req.query);
 

src/managers/organization/join.ts

@@ -20,6 +20,7 @@ import type {
 } from "@gouvfr-lasuite/proconnect.identite/types";
 import * as Sentry from "@sentry/node";
 import { isEmpty, some } from "lodash-es";
+import { AssertionError } from "node:assert";
 import { inspect } from "node:util";
 import {
   CRISP_WEBSITE_ID,
@@ -171,7 +172,13 @@ export const joinOrganization = async ({
   });
   if (!isEmpty(pendingModeration)) {
     const { id: moderation_id } = pendingModeration;
-    throw new UserAlreadyAskedToJoinOrganizationError(moderation_id);
+    throw new UserAlreadyAskedToJoinOrganizationError(moderation_id, {
+      cause: new AssertionError({
+        expected: undefined,
+        actual: pendingModeration,
+        operator: "findPendingModeration",
+      }),
+    });
   }
 
   const { id: organization_id, cached_libelle } = organization;

src/managers/user.ts

@@ -28,6 +28,7 @@ import {
 } from "@gouvfr-lasuite/proconnect.identite/types";
 import { to } from "await-to-js";
 import { isEmpty } from "lodash-es";
+import { AssertionError } from "node:assert";
 import {
   FRANCECONNECT_VERIFICATION_MAX_AGE_IN_MINUTES,
   HOST,
@@ -93,7 +94,13 @@ export const startLogin = async (
       didYouMean = getDidYouMeanSuggestion(email);
     }
 
-    throw new InvalidEmailError(didYouMean);
+    throw new InvalidEmailError(didYouMean, {
+      cause: new AssertionError({
+        actual: email,
+        expected: didYouMean,
+        operator: "isEmailSafeToSendTransactional",
+      }),
+    });
   }
 
   return {