📦 Migrate to otpauth library to enhance TOTP creactHmac import #1505
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
douglasduteil
changed the title
douglasduteil
force-pushed
the
refactor/migrate-totp-to-otpauth
branch
from
d1017ac to
cfe4f95
Compare
douglasduteil
changed the title
douglasduteil
changed the title
rdubigny
reviewed
Oct 22, 2025
Contributor
rdubigny
left a comment
rdubigny
left a comment
There was a problem hiding this comment.
thanks for this needed improvement.
Co-authored-by: Raphaël Dubigny <rdubigny@users.noreply.github.com>
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Mainly because
@sunknudsen/totpis not ES6 friendly see https://github.com/proconnect-gouv/proconnect-identite/actions/runs/18524754623/job/52792786552?pr=1499