diff --git a/src/connectors/brevo.ts b/src/connectors/brevo.ts index fc726a5d2..79793dd39 100644 --- a/src/connectors/brevo.ts +++ b/src/connectors/brevo.ts @@ -38,19 +38,6 @@ const remoteTemplateSlugToBrevoTemplateId: { "join-organization": 4, "verify-email": 6, }; -const localTemplateSlugs: LocalTemplateSlug[] = [ - "organization-welcome", - "unable-to-auto-join-organization", - "welcome", - "moderation-processed", - "delete-account", - "delete-free-totp", - "delete-access-key", - "add-access-key", - "update-totp-application", - "add-2fa", - "update-personal-data", -]; const defaultBrevoTemplateId = 7; const hasRemoteTemplate = ( @@ -58,10 +45,6 @@ const hasRemoteTemplate = ( ): template is RemoteTemplateSlug => remoteTemplateSlugToBrevoTemplateId.hasOwnProperty(template); -const isLocalTemplateSlug = (value: string): value is LocalTemplateSlug => { - return localTemplateSlugs.includes(value as LocalTemplateSlug); -}; - export const sendMail = async ({ to = [], cc = [], diff --git a/src/controllers/user/verify-email.ts b/src/controllers/user/verify-email.ts index e26326af2..604b10c38 100644 --- a/src/controllers/user/verify-email.ts +++ b/src/controllers/user/verify-email.ts @@ -32,11 +32,8 @@ export const getVerifyEmailController = async ( const { new_code_sent } = await schema.parseAsync(req.query); - const { - id: user_id, - email, - needs_inclusionconnect_onboarding_help, - } = getUserFromAuthenticatedSession(req); + const { email, needs_inclusionconnect_onboarding_help } = + getUserFromAuthenticatedSession(req); const codeSent: boolean = await sendEmailAddressVerificationEmail({ email, @@ -75,7 +72,7 @@ export const postVerifyEmailController = async ( const { verify_email_token } = await schema.parseAsync(req.body); - const { id: user_id, email } = getUserFromAuthenticatedSession(req); + const { email } = getUserFromAuthenticatedSession(req); const updatedUser = await verifyEmail(email, verify_email_token); @@ -104,7 +101,7 @@ export const postSendEmailVerificationController = async ( next: NextFunction, ) => { try { - const { id: user_id, email } = getUserFromAuthenticatedSession(req); + const { email } = getUserFromAuthenticatedSession(req); await sendEmailAddressVerificationEmail({ email, diff --git a/src/middlewares/user.ts b/src/middlewares/user.ts index 80d4f6300..eac46be7e 100644 --- a/src/middlewares/user.ts +++ b/src/middlewares/user.ts @@ -191,8 +191,7 @@ export const checkUserIsVerifiedMiddleware = ( try { if (error) return next(error); - const { id, email, email_verified } = - getUserFromAuthenticatedSession(req); + const { email, email_verified } = getUserFromAuthenticatedSession(req); const needs_email_verification_renewal = await needsEmailVerificationRenewal(email); @@ -238,7 +237,7 @@ export const checkUserHasPersonalInformationsMiddleware = ( try { if (error) return next(error); - const { given_name, family_name, phone_number, job } = + const { given_name, family_name, job } = getUserFromAuthenticatedSession(req); if (isEmpty(given_name) || isEmpty(family_name) || isEmpty(job)) { return res.redirect("/users/personal-information"); diff --git a/tsconfig.json b/tsconfig.json index c0eb0dbe1..45618cb1d 100644 --- a/tsconfig.json +++ b/tsconfig.json @@ -7,6 +7,7 @@ "module": "Preserve", "moduleResolution": "Bundler", "noFallthroughCasesInSwitch": true, + "noUnusedLocals": true, "outDir": "./build", "resolveJsonModule": true, "rootDir": "./src"