-
Notifications
You must be signed in to change notification settings - Fork 114
V2 Extensions as Middleware #539
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jhollinger
wants to merge
9
commits into
release-2.0
Choose a base branch
from
jh/rack-inspired-hooks
base: release-2.0
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
89c7e59 to
085c5dc
Compare
380635f to
cf8a28c
Compare
0bb37ea to
20c1304
Compare
Signed-off-by: Jordan Hollinger <jordan.hollinger@procore.com>
Signed-off-by: Jordan Hollinger <jordan.hollinger@procore.com>
20c1304 to
cbe9716
Compare
Signed-off-by: Jordan Hollinger <jordan.hollinger@procore.com>
Signed-off-by: Jordan Hollinger <jordan.hollinger@procore.com>
e2b6fc0 to
16ff30b
Compare
Signed-off-by: Jordan Hollinger <jordan.hollinger@procore.com>
45dd30d to
50f0f8b
Compare
Signed-off-by: Jordan Hollinger <jordan.hollinger@procore.com>
50f0f8b to
cf0c5b5
Compare
Signed-off-by: Jordan Hollinger <jordan.hollinger@procore.com>
Signed-off-by: Jordan Hollinger <jordan.hollinger@procore.com>
1df3087 to
0c7470d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A greatly simplified extension structure based around middleware instead of hooks. The extension system is comprised of multiple "stacks" of middlewares. A "render" fires off a nested call structure of these stacks:
Much like in Rack, each middleware receives a "context" and may choose to modify it before yielding to the next middleware. The yield returns the response, which the middleware may modify before returning. A middleware may choose not to yield at all and return a response of its choosing (e.g. a caching layer).
Instead of specialized hooks like
field_value,exclude_field?, andfield_result, a singlearound_field_valuehook can be used for anything relating to a field's value: