Skip to content

Conversation

cecille
Copy link
Contributor

@cecille cecille commented Oct 16, 2025

Summary

Removes TC-DD-3.9. Please do not merge until test plan changes are approved. See test plan PR for explanation.

Related issues

https://github.com/CHIP-Specifications/chip-test-plans/pull/5625

Testing

Deletion only.

Readability checklist

The checklist below will help the reviewer finish PR review in time and keep the
code readable:

  • PR title is
    descriptive
  • Apply the
    “When in Rome…”
    rule (coding style)
  • PR size is short
  • Try to avoid "squashing" and "force-update" in commit history
  • CI time didn't increase

See: Pull Request Guidelines

@cecille cecille marked this pull request as draft October 16, 2025 17:41
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the test case TC-DD-3.9. The changes involve deleting the test definition file src/app/tests/suites/certification/Test_TC_DD_3_9.yaml and removing its corresponding entry from the src/app/tests/suites/manualTests.json file. The changes are consistent and correctly execute the removal of the test case.

Copy link

github-actions bot commented Oct 16, 2025

PR #41485: Size comparison from 809986e to 6062934

Full report (37 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, nrfconnect, nxp, psoc6, qpg, realtek, stm32, telink)
platform target config section 809986e 6062934 change % change
bl602 lighting-app bl602+mfd+littlefs+rpc FLASH 1106116 1106116 0 0.0
RAM 178786 178786 0 0.0
bl702 lighting-app bl702+eth FLASH 660458 660458 0 0.0
RAM 134849 134849 0 0.0
bl702+wifi FLASH 836570 836570 0 0.0
RAM 124325 124325 0 0.0
bl706+mfd+rpc+littlefs FLASH 1069618 1069618 0 0.0
RAM 117181 117181 0 0.0
bl702l contact-sensor-app bl702l+mfd+littlefs FLASH 898442 898442 0 0.0
RAM 105444 105444 0 0.0
lighting-app bl702l+mfd+littlefs FLASH 982636 982636 0 0.0
RAM 109652 109652 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 FLASH 769988 769988 0 0.0
RAM 103240 103240 0 0.0
lock-ftd LP_EM_CC1354P10_6 FLASH 781752 781752 0 0.0
RAM 108392 108392 0 0.0
pump-app LP_EM_CC1354P10_6 FLASH 727940 727940 0 0.0
RAM 97308 97308 0 0.0
pump-controller-app LP_EM_CC1354P10_6 FLASH 712384 712384 0 0.0
RAM 97508 97508 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 554066 554066 0 0.0
RAM 205504 205504 0 0.0
lock CC3235SF_LAUNCHXL FLASH 586942 586942 0 0.0
RAM 205752 205752 0 0.0
efr32 lock-app BRD4187C FLASH 961832 961832 0 0.0
RAM 126268 126268 0 0.0
BRD4338a FLASH 757152 757152 0 0.0
RAM 255532 255532 0 0.0
window-app BRD4187C FLASH 1056900 1056900 0 0.0
RAM 122432 122432 0 0.0
esp32 all-clusters-app c3devkit DRAM 103160 103160 0 0.0
FLASH 1795908 1795908 0 0.0
IRAM 83862 83862 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 932836 932836 0 0.0
RAM 161033 161033 0 0.0
nxp contact mcxw71+release FLASH 691400 691400 0 0.0
RAM 61424 61424 0 0.0
lighting mcxw71+release FLASH 722896 722896 0 0.0
RAM 68084 68084 0 0.0
lock mcxw71+release FLASH 773168 773168 0 0.0
RAM 61868 61868 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 FLASH 1675868 1675868 0 0.0
RAM 213628 213628 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 FLASH 1591924 1591924 0 0.0
RAM 210924 210924 0 0.0
light cy8ckit_062s2_43012 FLASH 1458740 1458740 0 0.0
RAM 197648 197648 0 0.0
lock cy8ckit_062s2_43012 FLASH 1491148 1491148 0 0.0
RAM 225360 225360 0 0.0
qpg lighting-app qpg6200+debug FLASH 836128 836128 0 0.0
RAM 127644 127644 0 0.0
lock-app qpg6200+debug FLASH 772876 772876 0 0.0
RAM 118612 118612 0 0.0
realtek light-switch-app rtl8777g FLASH 706008 706008 0 0.0
RAM 106792 106792 0 0.0
lighting-app rtl8777g FLASH 757120 757120 0 0.0
RAM 127164 127164 0 0.0
stm32 light STM32WB5MM-DK FLASH 469612 469612 0 0.0
RAM 141248 141248 0 0.0
telink bridge-app tl7218x FLASH 710284 710284 0 0.0
RAM 90432 90432 0 0.0
light-app-ota-compress-lzma-shell-factory-data tl3218x FLASH 796492 796492 0 0.0
RAM 40928 40928 0 0.0
light-app-ota-shell-factory-data tl7218x FLASH 787692 787692 0 0.0
RAM 93572 93572 0 0.0
light-switch-app-ota-compress-lzma-factory-data tl7218x_retention FLASH 714618 714618 0 0.0
RAM 51732 51732 0 0.0
light-switch-app-ota-compress-lzma-shell-factory-data tlsr9528a FLASH 747922 747922 0 0.0
RAM 70780 70780 0 0.0
light-switch-app-ota-factory-data tl3218x_retention FLASH 724770 724770 0 0.0
RAM 34480 34480 0 0.0
lighting-app-ota-factory-data tlsr9118bdk40d FLASH 602010 602010 0 0.0
RAM 108620 108620 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d FLASH 820312 820316 4 0.0
RAM 91968 91968 0 0.0

Copy link

codecov bot commented Oct 16, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 51.00%. Comparing base (809986e) to head (6062934).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #41485      +/-   ##
==========================================
- Coverage   51.01%   51.00%   -0.02%     
==========================================
  Files        1385     1385              
  Lines      100969   100969              
  Branches    13073    13079       +6     
==========================================
- Hits        51513    51500      -13     
- Misses      49456    49469      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant