[Realtek] Modify path of examples #41500
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request refactors the Realtek example paths by renaming the bee directory to common, making the structure more generic. This change is applied consistently across multiple example applications (all-clusters-app, light-switch-app, lighting-app, lock-app, ota-requestor-app, thermostat, window-app) and the build scripts. Additionally, several README files have been updated to correct their titles and descriptions, which were previously inaccurate due to copy-pasting. The changes improve code organization and documentation clarity. I've found a few minor issues in the README files that could be addressed.
|
PR #41500: Size comparison from a95f163 to 158350b Full report (37 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, nrfconnect, nxp, psoc6, qpg, realtek, stm32, telink)
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #41500 +/- ##
=======================================
Coverage 51.01% 51.01%
=======================================
Files 1386 1386
Lines 100988 100988
Branches 13081 13081
=======================================
Hits 51519 51519
Misses 49469 49469 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
tcarmelveilleux
approved these changes
Oct 17, 2025
| add_subdirectory(${chip_dir}/third_party/pigweed/repo ${chip_dir}/examples/lighting-app/realtek/bee/out/pigweed) | ||
| add_subdirectory(${chip_dir}/third_party/nanopb/repo ${chip_dir}/examples/lighting-app/realtek/bee/out/nanopb) | ||
| add_subdirectory(${chip_dir}/examples/platform/realtek/pw_sys_io ${chip_dir}/examples/lighting-app/realtek/bee/out/pw_sys_io) | ||
| add_subdirectory(${chip_dir}/third_party/pigweed/repo ${chip_dir}/examples/lighting-app/realtek/common/out/pigweed) |
There was a problem hiding this comment.
PLACEHOLDER: Please merge master in your branch and fix conflicts. Merging is blocked by conflicts on a couple build files.
tcarmelveilleux
added
the
sdk-maintainer-approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Modify the path name of Realtek examples.
Testing
Tested manually by building these apps with latest docker container.