-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Disable ccache basedir rewrite in global configuration #41526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
PR #41526: Size comparison from ac328e4 to 264921e Full report (33 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, psoc6, qpg, realtek, stm32, telink)
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #41526 +/- ##
=======================================
Coverage 51.01% 51.02%
=======================================
Files 1386 1386
Lines 100982 100982
Branches 13076 13075 -1
=======================================
+ Hits 51520 51526 +6
+ Misses 49462 49456 -6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes NRF build failures by disabling ccache basedir rewrite in the global configuration while maintaining it for specific CI workflows. The change addresses issues introduced by PR #41503 where global ccache configuration was causing NRF builds to fail.
- Commented out global ccache environment variables in bootstrap script
- Added ccache configuration to specific CI workflows that need it
- Updated setup-ccache action to include the PREFIX_CPP configuration
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| scripts/setup/bootstrap.sh | Disabled global ccache BASEDIR and PREFIX_CPP exports by commenting them out |
| .github/workflows/examples-linux-standalone.yaml | Added CCACHE_BASEDIR and CCACHE_PREFIX_CPP environment variables |
| .github/workflows/examples-linux-arm.yaml | Added CCACHE_BASEDIR and CCACHE_PREFIX_CPP environment variables |
| .github/actions/setup-ccache/action.yml | Added CCACHE_PREFIX_CPP environment variable to the setup action |
|
PR #41526: Size comparison from ac328e4 to 8bde23e Full report (36 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, nxp, psoc6, qpg, realtek, stm32, telink)
|
…41526) * Disable ccache basedir rewrite in global configuration * Disable everything globally
Summary
This should fix NRF build fail on master after #41503 was merged.
Testing
CI should verify.
Verified locally that I can build NRF examples in nrf docker.