Update RayCluster labels to workload.codeflare.dev/appwrappers#384
Merged
openshift-ci[bot] merged 2 commits intoproject-codeflare:mainfrom Oct 25, 2023
Merged
Conversation
Contributor
Author
Contributor
|
Ran demo notebook and verified that ray cluster labels have been updated: |
Bobbins228
approved these changes
Oct 25, 2023
Contributor
Bobbins228
left a comment
Bobbins228
left a comment
There was a problem hiding this comment.
/approve Nice work Christian 👍
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Bobbins228 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue link
Closes #383
What changes have been made
Updated RayCluster labels from
appwrapper.mcad.ibm.comtoworkload.codeflare.dev/appwrapper.Note: further label updates will be done as part of this PR#652-MCAD based on the discussion.
Verification steps
Create a RayCluster and check its labels.
Checks