Skip to content

Conversation

GiroudMathias
Copy link

@GiroudMathias GiroudMathias commented Aug 30, 2023

Pull Request Description

Somes changes and optimisations:

  • When creating a conversation, redirect to it if exists
  • Message's search in name and number

Pull Request Checklist:

  • Have you followed the guidelines in our Contributing document and Code of Conduct?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you built and tested NPWD in-game after the relevant change?

Copy link
Author

@GiroudMathias GiroudMathias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On message, search user with number or contact name

return resp({
status: 'error',
errorMsg: 'MESSAGES.FEEDBACK.MESSAGE_CONVERSATION_DUPLICATE',
data: { id: await this.messagesDB.getConversationId(conversationList) }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please follow the pattern and call async function outside of the resp function

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants