-
Notifications
You must be signed in to change notification settings - Fork 703
docs: add method matching example for HTTPProxy using Envoy pseudo-headers #7230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add method matching example for HTTPProxy using Envoy pseudo-headers #7230
Conversation
Signed-off-by: Shivam Kumar <shivamkumar87148@gmail.com>
|
Hi @ShivamJha2436! Welcome to our community and thank you for opening your first Pull Request. Someone will review it soon. Thank you for committing to making Contour better. You can also join us on our mailing list and in our channel in the Kubernetes Slack Workspace |
|
The Contour project currently lacks enough contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to the #contour channel in the Kubernetes Slack |
|
/keep |
|
The Contour project currently lacks enough contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to the #contour channel in the Kubernetes Slack |
sunjayBhatia
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, just a tiny nit and we can merge this, thanks @ShivamJha2436 !
Signed-off-by: ShivamJha2436 <shivamkumar87148@gmail.com>
|
Hey @sunjayBhatia I made the changes PTAL. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7230 +/- ##
==========================================
+ Coverage 81.05% 81.85% +0.79%
==========================================
Files 130 130
Lines 19669 15747 -3922
==========================================
- Hits 15943 12889 -3054
+ Misses 3442 2574 -868
Partials 284 284 🚀 New features to boost your workflow:
|
tsaarni
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank You @ShivamJha2436!
Overview
This PR adds documentation for HTTP method-based routing in
HTTPProxyobjects using Envoy pseudo-headers (:method). While Contour supports routing based on path, headers, and query parameters, method matching was not clearly documented. This update provides guidance for users who want to route requests based on HTTP methods such as GET, POST, PUT, etc.What was changed
request-routing.md.:methodwith header conditions to implement method-based routing.Why this change is needed
HTTPProxy, even though it is supported via Envoy pseudo-headers.Example
This example demonstrates routing GET requests to get-service and POST requests to post-service.
Related Issue
Closes #5753 - Document how to do method matching in HTTPProxy