Apply new clippy lint fixes #375
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@waywardmonkeys Any idea off the top of your head how to deal with the other new lint not covered here yet involving mutable references to mutable static? |
Not offhand and don't have the time this week to dig into it. :( |
waywardmonkeys
approved these changes
Feb 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first commit here has some obvious fixes for convoluted code that has idiomatic Rust alternatives.
The second commit is for using lifetime elision instead of annotations. I understand this one is a bit more controversion and some projects have opted to ignore this lint instead. Personally I think I'm fine with it, I'd rather see annotations where they are meaningful and need to be included in reading the code to grok it, but if anybody here has issues with that I'm happy to consider ignoring these.