Replies: 3 comments 8 replies
-
Now regarding the design of |
Beta Was this translation helpful? Give feedback.
-
How should the @dataclass
class PropertyLayerStyle:
color: str | None
colormap: str | None
alpha: int = 1
colorbar: bool = True
vmin: float | None
vmax: float | None and usage: def propertylayer_portrayal(layer):
if layer.name == "sugar":
return PropertyLayerStyle(color="blue", alpha=0.8, colorbar=True, vmin=0, vmax=10)
else:
return PropertyLayerStyle(color="red", alpha=0.5, colorbar=True, vmin=0, vmax=10) Is this approach correct? How it can be improved (if it can)? |
Beta Was this translation helpful? Give feedback.
-
@quaquel, @EwoutH, @tpike3 and @jackiekazil, I should have asked this first—please list all the critiques of the proposal, including what was good, what wasn't, and how it can be improved. |
Beta Was this translation helpful? Give feedback.
-
Hi I am @Sahil-Chhoker, I am having some problems with my main account therefore opening this discussion with an alternate account. @tpike3, we can discuss the ideas and feedback for my proposal in this discussion. It will also act like a journal to document my development.
Here is the crux of my proposal:
Phase 1:
AgentPortrayalStyle
andPropertlyLayerStyle
:CoordinateMapper
:CoordinateMapper
acts as a layer betweenSpaceMatplotlib
anddraw_space
. The signatures ofdraw_space
will be updated to include the mapper class.SpaceRenderer
:Phase 2:
Timeline:
AgentPortrayalStyle
andPropertyLayerStyle
CoordinateMapper
SpaceRenderer
Altair
backend inline withmatplotlib
.Beta Was this translation helpful? Give feedback.
All reactions