Fix intermittent test failure in WriterTest #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test teardown had a race condition where the mock_socket_state process could terminate between checking its existence and attempting to stop it. This caused Agent.stop/1 to fail with "no process" errors. Fixed by: - Capturing PID first to avoid TOCTOU issues - Checking if process is alive before stopping - Wrapping stop call in try/catch for graceful error handling - Adding timeout to prevent hanging
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test teardown had a race condition where the mock_socket_state process could terminate between checking its existence and attempting to stop it. This caused Agent.stop/1 to fail with "no process" errors.
Fixed by: