Skip to content

chore(aws): enhance metadata for ecr service#8872

Merged
HugoPBrito merged 4 commits intomasterfrom
review_metadata_aws_ecr
Nov 17, 2025
Merged

chore(aws): enhance metadata for ecr service#8872
HugoPBrito merged 4 commits intomasterfrom
review_metadata_aws_ecr

Conversation

@puchy22
Copy link
Copy Markdown
Member

@puchy22 puchy22 commented Oct 8, 2025

Context

Updating aws ecr service metadata to conform with the new standardized metadata format used across Prowler checks, defined in #8411.

Description

This PR updates all metadata files for AWS ECR checks to adapt to the new metadata format. The changes ensure consistency with the metadata structure being adopted across all Prowler services. The modified checks are:

  • ecr_registry_scan_images_on_push_enabled
  • ecr_repositories_lifecycle_policy_enabled
  • ecr_repositories_not_publicly_accessible
  • ecr_repositories_scan_images_on_push_enabled
  • ecr_repositories_scan_vulnerabilities_in_latest_image
  • ecr_repositories_tag_immutability

Checklist

API

  • Verify if API specs need to be regenerated.
  • Check if version updates are required (e.g., specs, Poetry, etc.).
  • Ensure new entries are added to CHANGELOG.md, if applicable.

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@puchy22 puchy22 requested review from a team as code owners October 8, 2025 10:41
@github-actions github-actions bot added the provider/aws Issues/PRs related with the AWS provider label Oct 8, 2025
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Oct 8, 2025

✅ All necessary CHANGELOG.md files have been updated.

@codecov
Copy link
Copy Markdown

codecov bot commented Oct 8, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.58%. Comparing base (4167de3) to head (4da3ceb).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8872      +/-   ##
==========================================
+ Coverage   86.63%   90.58%   +3.95%     
==========================================
  Files         914      834      -80     
  Lines       29216    23532    -5684     
==========================================
- Hits        25310    21317    -3993     
+ Misses       3906     2215    -1691     
Flag Coverage Δ
prowler-py3.10-aws 90.56% <ø> (+0.01%) ⬆️
prowler-py3.10-lib ?
prowler-py3.11-aws 90.55% <ø> (+0.02%) ⬆️
prowler-py3.11-lib ?
prowler-py3.12-aws 90.56% <ø> (+0.02%) ⬆️
prowler-py3.12-lib ?
prowler-py3.9-aws 90.53% <ø> (-0.01%) ⬇️
prowler-py3.9-lib ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
prowler 90.58% <ø> (+3.95%) ⬆️
api ∅ <ø> (∅)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@HugoPBrito HugoPBrito self-assigned this Nov 6, 2025
@github-actions
Copy link
Copy Markdown
Contributor

Conflict Markers Resolved

All conflict markers have been successfully resolved in this pull request.

@github-actions
Copy link
Copy Markdown
Contributor

🔒 Container Security Scan

Image: prowler:ddf9dab
Last scan: 2025-11-17 09:28:14 UTC

📊 Vulnerability Summary

Severity Count
🔴 Critical 2
Total 2

2 package(s) affected

⚠️ Action Required

Critical severity vulnerabilities detected. These should be addressed before merging:

  • Review the detailed scan results
  • Update affected packages to patched versions
  • Consider using a different base image if updates are unavailable

📋 Resources:

@HugoPBrito HugoPBrito merged commit e715b9f into master Nov 17, 2025
32 checks passed
@HugoPBrito HugoPBrito deleted the review_metadata_aws_ecr branch November 17, 2025 10:50
Hamza-abughazaleh pushed a commit to Raed-sh/prowler that referenced this pull request Feb 11, 2026
Co-authored-by: HugoPBrito <hugopbrit@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

metadata-review provider/aws Issues/PRs related with the AWS provider

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants