Skip to content

Conversation

@HugoPBrito
Copy link
Member

@HugoPBrito HugoPBrito commented Oct 14, 2025

Context

Possible improvements were detected in the deprecation of user and password authentication for Microsoft 365 in the API, and they will be implemented in this PR

Description

Deprecation status has been added to user and password parameters.

In the previous deprecation, the certificate authentication method was incorrectly given user and password parameters, which are not required. These have now been removed and kept only where appropriate.

Steps to review

Please add a detailed description of how to review this PR.

Checklist

API

  • Verify if API specs need to be regenerated.
  • Check if version updates are required (e.g., specs, Poetry, etc.).
  • Ensure new entries are added to CHANGELOG.md, if applicable.

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@HugoPBrito HugoPBrito requested a review from a team as a code owner October 14, 2025 14:57
@HugoPBrito HugoPBrito added the no-merge Please, DO NOT MERGE this PR. label Oct 14, 2025
@github-actions github-actions bot added component/api and removed no-merge Please, DO NOT MERGE this PR. labels Oct 14, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Oct 14, 2025

⚠️ Changes detected in the following folders without a corresponding update to the CHANGELOG.md:

  • api

Please add an entry to the corresponding CHANGELOG.md file to maintain a clear history of changes.

@codecov
Copy link

codecov bot commented Oct 14, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.62%. Comparing base (20314ca) to head (b252c89).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #8913       +/-   ##
===========================================
+ Coverage   73.50%   94.62%   +21.12%     
===========================================
  Files          75      135       +60     
  Lines        5416    15244     +9828     
===========================================
+ Hits         3981    14425    +10444     
+ Misses       1435      819      -616     
Flag Coverage Δ
api 94.62% <ø> (?)
prowler ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
prowler ∅ <ø> (∅)
api 94.62% <ø> (∅)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@HugoPBrito HugoPBrito changed the title fix(api): m365 user auth deprecation chore(api): enhance m365 user auth deprecation Oct 14, 2025
@HugoPBrito
Copy link
Member Author

image image

Co-authored-by: Víctor Fernández Poyatos <victor@prowler.com>
@vicferpoy vicferpoy added the no-changelog Skip including change in changelog/release notes label Oct 15, 2025
@vicferpoy vicferpoy merged commit 8773751 into master Oct 15, 2025
17 checks passed
@vicferpoy vicferpoy deleted the PRWLR-8337-soft-deprecate-user-auth-in-api branch October 15, 2025 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component/api no-changelog Skip including change in changelog/release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants