Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
allow SDL to be built without IOP handling
new make variable
NO_IOP_HANDLING
will disable features that have influence over the iop, such as loading modules and rebooting the IOPThe RPC EE servers remain bc they are obviously needed
Fix IRX return value check on SDL
Module ID being less <= 0 means that MODLOAD returned an error (see
kerr.h
)Now, for the module return value...
((ret & 3) != 0)
is the condition used byrom0:MODLOAD
to check if module requested to be unloaded from it's main function (eg: aborted startup, whatever...). newer modloads use a different (and not backwards compatible) logic. so this new logic will work as intended as long as the program using this library did not replace the MODLOAD module with one that supports unloading...This is MUCH better than the old flawed logic. since SDL will no longer deem a module returning
MODULE_NO_RESIDENT_END
as successfully executed