test: ensure firstOrCreate/New work in 6.x/8.x

Author: caugner

tests/acceptance/EloquentBuilderTypes.feature

@@ -165,3 +165,62 @@ Feature: Eloquent Builder types
     """
     When I run Psalm
     Then I see no errors
+
+  Scenario: cannot call firstOrNew and firstOrCreate without parameters in Laravel 6.x
+    Given I have the "laravel/framework" package satisfying the "6.*"
+    And I have the following code
+    """
+    <?php declare(strict_types=1);
+
+    use Tests\Psalm\LaravelPlugin\Models\User;
+    use \Illuminate\Database\Eloquent\Builder;
+
+    /**
+    * @psalm-param Builder<User> $builder
+    * @psalm-return User
+    */
+    function test_firstOrCreate(Builder $builder): User {
+      return $builder->firstOrCreate();
+    }
+
+    /**
+    * @psalm-param Builder<User> $builder
+    * @psalm-return User
+    */
+    function test_firstOrNew(Builder $builder): User {
+      return $builder->firstOrNew();
+    }
+    """
+    When I run Psalm
+    Then I see these errors
+      | Type  | Message |
+      | TooFewArguments | Too few arguments for method Illuminate\Database\Eloquent\Builder::firstorcreate saw 0 |
+      | TooFewArguments | Too few arguments for method Illuminate\Database\Eloquent\Builder::firstornew saw 0    |
+
+  Scenario: can call firstOrNew and firstOrCreate without parameters in Laravel 8.x
+    Given I have the "laravel/framework" package satisfying the ">= 8.0"
+    And I have the following code
+    """
+    <?php declare(strict_types=1);
+
+    use Tests\Psalm\LaravelPlugin\Models\User;
+    use Illuminate\Database\Eloquent\Builder;
+
+    /**
+    * @psalm-param Builder<User> $builder
+    * @psalm-return User
+    */
+    function test_firstOrCreate(Builder $builder): User {
+      return $builder->firstOrCreate();
+    }
+
+    /**
+    * @psalm-param Builder<User> $builder
+    * @psalm-return User
+    */
+    function test_firstOrNew(Builder $builder): User {
+      return $builder->firstOrNew();
+    }
+    """
+    When I run Psalm
+    Then I see no errors

tests/acceptance/EloquentRelationTypes.feature

@@ -356,3 +356,56 @@ Feature: Eloquent Relation types
     """
     When I run Psalm
     Then I see no errors
+
+  Scenario: cannot call firstOrNew and firstOrCreate without parameters in Laravel 6.x
+    Given I have the "laravel/framework" package satisfying the "6.*"
+    And I have the following code
+    """
+    function test_hasOne_firstOrCreate(User $user): Phone {
+      return $user->phone()->firstOrCreate();
+    }
+
+    function test_hasOne_firstOrNew(User $user): Phone {
+      return $user->phone()->firstOrNew();
+    }
+
+    function test_hasMany_firstOrCreate(Post $post): Comment {
+      return $post->comments()->firstOrCreate();
+    }
+
+    function test_hasMany_firstOrNew(Post $post): Comment {
+      return $post->comments()->firstOrNew();
+    }
+    """
+    When I run Psalm
+    Then I see these errors
+      | Type  | Message |
+      | TooFewArguments | Too few arguments for method Illuminate\Database\Eloquent\Relations\HasOneOrMany::firstorcreate saw 0 |
+      | TooFewArguments | Too few arguments for method Illuminate\Database\Eloquent\Relations\HasOneOrMany::firstornew saw 0    |
+      | TooFewArguments | Too few arguments for method Illuminate\Database\Eloquent\Relations\HasOneOrMany::firstorcreate saw 0 |
+      | TooFewArguments | Too few arguments for method Illuminate\Database\Eloquent\Relations\HasOneOrMany::firstornew saw 0    |
+
+
+  Scenario: can call firstOrNew and firstOrCreate without parameters in Laravel 8.x
+    Given I have the "laravel/framework" package satisfying the ">= 8.0"
+    And I have the following code
+    """
+    function test_hasOne_firstOrCreate(User $user): Phone {
+      return $user->phone()->firstOrCreate();
+    }
+
+    function test_hasOne_firstOrNew(User $user): Phone {
+      return $user->phone()->firstOrNew();
+    }
+
+    function test_hasMany_firstOrCreate(Post $post): Comment {
+      return $post->comments()->firstOrCreate();
+    }
+
+    function test_hasMany_firstOrNew(Post $post): Comment {
+      return $post->comments()->firstOrNew();
+    }
+    """
+    When I run Psalm
+    Then I see no errors
+