Skip to content

SuppressHandler doesn't work with 2 levels inheritance #340

Open
@palviggi-videoslots

Description

@palviggi-videoslots

I had a lot of Commands with common functionality. I moved the common features into an abstract class and made all my commands extend from it. Now I have lots of messages in the psalm out put about PropertyNotSetInConstructor [...]$laravel as well as $name, $input and $output.

Those are normally suppressed by the BY_PARENT_CLASS rules, but there's an order of execution problem: AfterClassLikeVisit can be called before populate, at which point we only have 1 level of parent classes available to compare.

I guess one option could be to change it into AfterCodebasePopulatedInterface, and analyze all available classes at that point, not sure how much change it would be

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions