Skip to content

Fix #483 #484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 22, 2025
Merged

Fix #483 #484

merged 2 commits into from
Aug 22, 2025

Conversation

pschachte
Copy link
Owner

Check writeability of destination object file before writing .ll file, and change destination to cache directory if it's not writeable.

@jimbxb jimbxb self-requested a review August 21, 2025 13:23
jimbxb
jimbxb approved these changes Aug 21, 2025
View reviewed changes
Copy link
Collaborator

@jimbxb jimbxb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I assume this works on your machine too, which gives us coverage of Ubuntu and MacOS :)

@pschachte pschachte merged commit 5e09f81 into master Aug 22, 2025
1 check passed
@pschachte pschachte deleted the local-obj-fix branch August 22, 2025 00:41
@pschachte pschachte restored the local-obj-fix branch August 22, 2025 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jimbxb jimbxb jimbxb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pschachte @jimbxb