Use full path for cross file links#444
Draft
renjiexu wants to merge 1 commit into
Draft
Conversation
|
Bumping this, would be really interested here as well. We have way too many protos to comfortably fit on one page, so the per-folder or per-package approach with cross-linking would be perfect. |
Author
|
@alkasm good to know, I have a working solution for HTML/markdown in my forked version, will try to fix the unitest so we could have a clean PR to merge |
|
I think I found an issue with the generated links for nested message definitions. If you have Then |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi team,
In our company, we're using namespace such as following:
instead of generating one html for all the *.proto, we generate one for each namespace:
However, if
webhook.protorefers a type inaccount_api.proto, the link would not work.This PR would address the problem, confirmed it's working for me, would like your thoughts on this before adding specs.
(might be able to solve the request of #406)
Thanks,
Renjie