Skip to content

Commit 9bba7f8

Browse files
committed
Don't login to docker hub on pull requests
1 parent 3ebcf60 commit 9bba7f8

File tree

2 files changed

+3
-1
lines changed

2 files changed

+3
-1
lines changed

.github/workflows/BuildPublishPipeline.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -34,8 +34,10 @@ jobs:
3434

3535
# https://github.com/marketplace/actions/docker-login
3636
- name: 'Login to Docker Hub'
37+
if: ${{ github.event_name != 'pull_request' }}
3738
uses: docker/login-action@v2
3839
with:
40+
registry: docker.io
3941
username: ${{ secrets.DOCKER_HUB_USERNAME }}
4042
password: ${{ secrets.DOCKER_HUB_ACCESS_TOKEN }}
4143

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ Docker image is based on [LinuxServer.io Code-Server](https://github.com/linuxse
1616
## Container Images
1717

1818
Docker container images are published on [Docker Hub](https://hub.docker.com/r/ptr727/vscode-server-dotnetcore).
19-
Multi-Architecture images are created for `linux/amd64` and `linux/arm64` (`linux/arm/v7` is [not longer supported](https://www.linuxserver.io/blog/a-farewell-to-arm-hf) by LSIO).
19+
Multi-Architecture images are created for `linux/amd64` and `linux/arm64` (`linux/arm/v7` is [not supported](https://www.linuxserver.io/blog/a-farewell-to-arm-hf) by LSIO).
2020
Tags are `latest` for `main` branch and `develop` for `develop` branch.
2121
E.g. `docker pull ptr727/vscode-server-dotnetcore:latest`
2222
E.g. `docker pull ptr727/vscode-server-dotnetcore:develop`

0 commit comments

Comments
 (0)