Skip to content

deps: Update keytar and whats-my-line (allows building on Node 18 or newer) #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 9 commits into
base: master
Choose a base branch
from
Draft

deps: Update keytar and whats-my-line (allows building on Node 18 or newer) #35

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
06e7dfa
deps: Update keytar to 7.9.0 (drops nan --> N-API)
DeeDeeG Sep 22, 2023
6f29e82
CI: Empty commit to re-run CI
DeeDeeG Nov 7, 2023
332428c
CI: Use --legacy-peer-deps for newer npm in Lint job
DeeDeeG Nov 7, 2023
d74139e
CI: Install Python setuptools
DeeDeeG Nov 7, 2023
4229a3b
deps: Bump nan in package-lock.json only
DeeDeeG Nov 7, 2023
c2500ba
deps: Update whats-my-line to Pulsar's fork
DeeDeeG Nov 9, 2023
e9ef22e
meta: Fresh package-lock.json made with ppm
DeeDeeG Nov 9, 2023
d3c42e5
deps: Get whats-my-line as a tarball URL, not a git URL
DeeDeeG Nov 10, 2023
405e12b
deps: Update whats-my-line to latest commit
DeeDeeG Nov 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,12 @@ jobs:

- name: Setup Pulsar Editor
uses: pulsar-edit/action-pulsar-dependency@v3.2

- name: Install Python setuptools
# This is needed for Python 3.12+, since many versions of node-gyp
# are incompatible with Python 3.12+, which no-longer ships 'distutils'
# out of the box. 'setuptools' package provides 'distutils'.
run: python3 -m pip install setuptools

- name: Install dependencies (Windows)
if: ${{ runner.os == 'Windows' }}
Expand Down Expand Up @@ -59,7 +65,7 @@ jobs:
with:
node-version: 'lts/*'
- name: NPM install
run: npm install
run: npm install --legacy-peer-deps
- name: Lint ✨
run: npm run lint

Loading