Install required packages and locales before installation #632
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
bastelfreak
reviewed
Oct 27, 2025
| #!/bin/sh | ||
|
|
||
| # Setup required packages | ||
| packages="curl gnupg" |
There was a problem hiding this comment.
it would be awesome if the installer itself would already handle this. Then it will work for people that directly use the installer.
There was a problem hiding this comment.
curl and gnupg are used by peadm when downloading the installer package not by puppet-enterprise-installer.
Generating en_US.UTF-8 might be more appropriate within the PuppetDB installation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Some operating systems don't have all required packages and locales installed by default.
This PR ensures
curlandgnupgare installed for the enterprise install script, and that localeen_US.UTF-8is generated for PuppetDB.Checklist
Changes include test coverage?
Have you updated the documentation?