(CAT-2083) - Modernize module #414
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jordanbreen28
force-pushed
the
cat-2083-modernise_puppetlabs_testing
branch
9 times, most recently
from
cee26f9 to
1f33307
Compare
| secrets: "inherit" | ||
|
|
||
| Acceptance: | ||
| uses: "puppetlabs/cat-github-actions/.github/workflows/module_acceptance.yml@main" |
There was a problem hiding this comment.
just curious do we need @main or does it know the latest?
There was a problem hiding this comment.
we pull off the main branch just
jordanbreen28
force-pushed
the
cat-2083-modernise_puppetlabs_testing
branch
from
1f33307 to
1e13475
Compare
danadoherty639
previously approved these changes
Oct 10, 2024
jordanbreen28
force-pushed
the
cat-2083-modernise_puppetlabs_testing
branch
from
1e13475 to
05364da
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this module is important for the testing of internal services. As such, as should update it to ensure it is consistent with other modules owned by puppet.